Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751884AbdIOTkA (ORCPT ); Fri, 15 Sep 2017 15:40:00 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:38958 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751619AbdIOTj6 (ORCPT ); Fri, 15 Sep 2017 15:39:58 -0400 To: Colin King Cc: James Smart , Dick Kennedy , "James E . J . Bottomley" , "Martin K . Petersen" , linux-scsi@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] scsi: lpfc: remove redundant null check on eqe From: "Martin K. Petersen" Organization: Oracle Corporation References: <20170908080201.9592-1-colin.king@canonical.com> Date: Fri, 15 Sep 2017 15:39:48 -0400 In-Reply-To: <20170908080201.9592-1-colin.king@canonical.com> (Colin King's message of "Fri, 8 Sep 2017 09:02:01 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Source-IP: aserv0022.oracle.com [141.146.126.234] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 230 Lines: 10 Colin, > The pointer eqe is always non-null inside the while loop, so the check > to see if eqe is NULL is redudant and hence can be removed. Applied to 4.15/scsi-queue. Thanks! -- Martin K. Petersen Oracle Linux Engineering