Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751926AbdIOTmY (ORCPT ); Fri, 15 Sep 2017 15:42:24 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:40486 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751730AbdIOTmW (ORCPT ); Fri, 15 Sep 2017 15:42:22 -0400 To: Colin King Cc: Joao Pinto , Vinayak Holikatti , "James E . J . Bottomley" , "Martin K . Petersen" , linux-scsi@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] scsi: ufs: tc-dwc-g210: make arrays static, reduces object code size From: "Martin K. Petersen" Organization: Oracle Corporation References: <20170912113228.1389-1-colin.king@canonical.com> Date: Fri, 15 Sep 2017 15:42:10 -0400 In-Reply-To: <20170912113228.1389-1-colin.king@canonical.com> (Colin King's message of "Tue, 12 Sep 2017 12:32:28 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Source-IP: aserv0021.oracle.com [141.146.126.233] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 208 Lines: 10 Colin, > Don't populate const arrays on the stack, instead make them static. > Makes the object code smaller by over 740 bytes. Applied to 4.15/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering