Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751673AbdIOUN3 (ORCPT ); Fri, 15 Sep 2017 16:13:29 -0400 Received: from mail-by2nam01on0076.outbound.protection.outlook.com ([104.47.34.76]:39328 "EHLO NAM01-BY2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751545AbdIOUN1 (ORCPT ); Fri, 15 Sep 2017 16:13:27 -0400 Authentication-Results: spf=pass (sender IP is 208.19.100.20) smtp.mailfrom=microsemi.com; suse.cz; dkim=none (message not signed) header.d=none;suse.cz; dmarc=bestguesspass action=none header.from=microsemi.com; From: Dave Carroll To: Nikola Pajkovsky , dl-esc-Aacraid Linux Driver CC: Hannes Reinecke , "James E.J. Bottomley" , "Martin K. Petersen" , "linux-scsi@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: RE: [PATCH] scsi: aacraid: error: testing array offset 'bus' after use Thread-Topic: [PATCH] scsi: aacraid: error: testing array offset 'bus' after use Thread-Index: AQHTLGzJ9eHwGymlIUyzUVU7m34CHqK2ZJCA Date: Fri, 15 Sep 2017 20:13:22 +0000 Message-ID: <423FD6710FB8FB4F8728F93591889F9A5B8BCD39@avsrvexchmbx1.microsemi.net> References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.100.34.10] Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report: CIP:208.19.100.20;IPV:NLI;CTRY:US;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(376002)(346002)(39860400002)(2980300002)(438002)(189002)(199003)(106466001)(54356999)(49446005)(76176999)(50986999)(68736007)(69596002)(53416004)(189998001)(7696004)(23726003)(3846002)(104016004)(2950100002)(2920100001)(2900100001)(5660300001)(6116002)(102836003)(33656002)(55846006)(8936002)(2906002)(47776003)(81156014)(7736002)(356003)(305945005)(8676002)(81166006)(8746002)(50466002)(5250100002)(86362001)(46406003)(53936002)(97756001)(316002)(229853002)(54906002)(478600001)(4326008)(6246003)(9686003)(97736004)(6636002);DIR:OUT;SFP:1101;SCL:1;SRVR:BY2PR0201MB1446;H:avsrvexchhts2.microsemi.net;FPR:;SPF:Pass;PTR:InfoDomainNonexistent;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;BN1BFFO11FD042;1:633Jm6AaGRFkEVaPu3vcl1+6ZHarRzBbkz4P9XPMvucwpUA4fB57jeTUNil5PVBkHD1x1zkePs+9FEw3UvXWP2c1KlkyX9qXMVTiC1vJSV00UX+phRuGL+7azf3Wbb8O X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: a5eec132-d554-460c-c752-08d4fc763816 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(8251501002)(300000503095)(300135400095)(2017052603199)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095);SRVR:BY2PR0201MB1446; X-Microsoft-Exchange-Diagnostics: 1;BY2PR0201MB1446;3:a3bQakjI0ImByX6I7IrwpIQWfieMzo4Tk3w4uXokHrXZnk+Bj75TtUL+VeNURmprSHHB2TNZzoDrN4rO7eOn+b8S85tMpyFJ1dviuf0QHaqUvlgDgwpyHeoGR1vziXmxy1ULmL4L5EGlgqf7IkQGRiZ+mpeXquAREvtvuotQGABJ/T67niUID1NIRPYTEOvxNU/ty3tFOQmQIqiTMVqyD1uR7GF1enOBAx9/szhxNaYXQFM+GENpsokK97OaoWglqaOlX/FiejBVPKf5v/C2OIYB9Qb7VhUSRayhtN2ec95/ggE5aIdrO+mh7jTxasZgF8f5aT5GnMk1ogOpmuI2CSG72IB4TtNN5q9nYvUiS24=;25:JdeVRMXZiLKmjif4i68y2bEiHePc9s1VNGWYqFrOF1nJzjYaGnt4hZEpo6WdOhq64XUNWlm5+7f3mRbj9eCZcQs0olQH6nFqz0VYUawCmnGVzND1onkhTlQp98gclmZYxUMI3OoNmSdbdzMh5pnXpsrjfSwzQbYMVXSjhB3Ro3RirmvJJBFVrXJP7pQI9d9grRG6DzYqrdBRANdntr7zKavhzeTMy4QSuggUfEgrBoMzWQ0ROsu/sDNH43gaphRuFAVs+zxDfwfDwpvau3/IMNS+UY9CJx7UfUskRGYuJRBvtYqD3kR3yj2bZXJMz5Wo6Igr1Sk6/JVmfe55oKwhkg== X-MS-TrafficTypeDiagnostic: BY2PR0201MB1446: X-Microsoft-Exchange-Diagnostics: 1;BY2PR0201MB1446;31:tjhmN9n4npYVTbZ/pwvDgvUAUYpwfy9qevXL0Usye50EZhLyuK27Hk4IiP5B2Db2w6NiGiU74xdWd8nXmQ+8RnVF5wsV6aLj/ASXQANYyeY0FDeXP9rGCMVdDrHRGNVIPdPkJ0ipTnKSc6aeAt8VXqoNrlQ/hA9rWzLhGW06F0uYypt4Cwldfe8ZtdU6Wh9cS3n44i971SvvMiSffV44KlLJQ75CFn/uoqmv9Pv3viw=;20:zyP0/yq9JD6XPb9HNloLJiSPKAZqgUs8EYPOxPIWNtuHEMeoIOF0ZZQ6dbMoX4dQl9dyvteJ/v/Q1NAVu3PBy546l/9DRBPxmbazIwNpnrG/4gmB+tO5ZXw3GFmtuUAUJVhxJgBaIXyYBhIXbX2p404Pc86JcmNywkdNHi2tSzbURGVGb5mspPW3bk+t703QXT13T4pqtUvp4d/z+W4qGCr8paka7CCWkB6gRP6pzazmDOPkXGsRvHfdNWczmF9LZ5WcVrmZmgqDFa1gzWnHzKr6UEQ04uX4qcOQwhZG+M8VPSqCwLNYajyX9x0t+kq3oBreQlt36fxxWFHVAMJvkvmSgL0M9eJacdPusWgRQjhD7rB6LVzmF6ao7ZAOk7/1RuyVg1LOWffU1vR3rc2QOW+q1avcxIbLAHkWGAsN0luKmbZt1arcwE2MWbNpbR3UHkSR6Bb7d79Os+R4TFVq9hxCTQv3eTLcTAqmXErIPy/ysyscr08msRWpAFA0B0J7 X-Exchange-Antispam-Report-Test: UriScan:(72170198267865); X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(93006095)(93004095)(100000703101)(100105400095)(3002001)(10201501046)(6055026)(6041248)(20161123560025)(20161123555025)(20161123562025)(20161123564025)(20161123558100)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:BY2PR0201MB1446;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:BY2PR0201MB1446; X-Microsoft-Exchange-Diagnostics: 1;BY2PR0201MB1446;4:dJPfZpPnBsiP32r6zre5MZliAXUWGo+yv4jpNEI4A9Fv/9j72aViSY4I2uRjhYHusTftw7q70okiJPFVRe1O4n7Hb/MOBOJpEf1XhotPYL5mv7mpnl1QdeHinBHnJ+fKk+KXvzSd5PUpBPgf0BucA1jKPYH7zEU1bs6XhMUZwW6Hfs+S0vZTgF8vmBY6E8OZtZAK2KtBLJAIIGH0W37Hh3i2FAs8QxCddPWIss9B6KeUQsceMX7I5SqkJ45amN33qjXg5n8QKtlfgPucM0nOqUxSRTpSESrD0dC/McVaKZY= X-Forefront-PRVS: 0431F981D8 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;BY2PR0201MB1446;23:MRQ2yyzLqWHowYlfv4AOsNQ1MRR7pHTkws+Fm8B?= =?us-ascii?Q?6n6i+21kH7dmT5t+rmEF++/vxhk4noKCnKq6+3jM/2AMv4bkQ+dueWa7QHvg?= =?us-ascii?Q?PyK/YzTbcqAjljN+RhIcY2TMNEhuNp3QMQUQN4kUAKR21nHHfyo8puBvHd+v?= =?us-ascii?Q?/fBnx69WnFFNKMkD5s112YJkApwHVreA9/s5hR3IV4dNPWqJ8g/GjrVWaHKY?= =?us-ascii?Q?Q3kkoVF4w1FKv6SOvSS0U9+1mrm9r7HtNDacyCGr6Vu6GY1o8xgXoYLHML9I?= =?us-ascii?Q?W5Kxzmr60te1zt2Y7ZPYzp5pr8SKIG+4I3KfEiaDod0NiKC6C1j+hnszHDdk?= =?us-ascii?Q?VqxQizIPRuE3U7yx7PGGzpI90Rtw8NzvWkoVkjxL8L5EMqbdvrMD7aWIOTFM?= =?us-ascii?Q?clYRcZbE7W/9OdPzKGBDzcD2knJqnY6qmrtAXdb5YDLH13SEAeY7GrlRz43Z?= =?us-ascii?Q?uyDv6I6hSJjWfxGU68fgL7KehvIkXXF+mxz6g5UWN3m6YCDI9kxFvwJ/Vm8Q?= =?us-ascii?Q?bUETJLCjOBHQq01yZCPeL/KiSOsU2mbuRDLavn/PiOh227i5HzW/NhLll7XU?= =?us-ascii?Q?vqq2GZ/XvCtHdkdCGuFTVPZqdoM2UOOQrukq2r+vXTCZvDFmNhOSeziOd0Tu?= =?us-ascii?Q?6fjTAq6dR3qehYzZmqeStgsaHYUbxVnxHt24NbtlQnFUWwhfK59LnFhyuItQ?= =?us-ascii?Q?w1vAMdckCLF5l2+EluKS/TXMsId5HdP3PYgQN06+SF2txiKybs1gIau9vRuB?= =?us-ascii?Q?mFiq+/4eHyPFESUJ1xbqCJohst1JB4SB9pSgZOSEZsapvMwPCv/F4tFF3qL8?= =?us-ascii?Q?pYsjEw3PHLEpgYVjFsN6d8UtgRSaXA49t4j57vkjoD0Jb4Nl9vcCX3dRg6Jv?= =?us-ascii?Q?zzl3cHPPBOTNtysL3SRJa/Pl+aDMfO8ZaBWtAm0KX65DPKkpJzi5HHe4LpOX?= =?us-ascii?Q?gmix59YwtnRq0bu6m/6rMnYvurH02Oab6kHsHbtfSPO8TsrVG8sseBvz/s0l?= =?us-ascii?Q?tQQgkzZBR71xd/iAn5Rk7I2HWQQ80H2/NFkqiIq8JA8x+w0gmWAhWl9th4mw?= =?us-ascii?Q?xqxoV/xheXXzRHDEXxCyyzvVfpwwDt1R2D4wcCt4qA1v5Wq5duxYPBktv1X/?= =?us-ascii?Q?k2z4N1tlkPN2af0+0Yvx9l6ZsriI++iF9ZQp52x6HUq/flYd0X8CCPcQrElh?= =?us-ascii?Q?dyo+YjY/tdkveiAgI3ecVvDdlqyBJ/fs4EJvvxovNl/y8cKl1/I2FpixArSz?= =?us-ascii?Q?gaf5yatD5spsb88uGqnA=3D?= X-Microsoft-Exchange-Diagnostics: 1;BY2PR0201MB1446;6:jMEf/DVDWUJ5xoxZ3QlsAyiKG24x+MXEt4e6jk94HX3iORQlKyTWpMYCISrLOfnZyaPJ/nCbag28kTTOMlDGa948WjHUYiLGjbHx+tl+KMBvRKmArfiTaaKs7xt/AwlmkuokSoJsneITJVbSWhKa1Q/S8stIEQyy5pbSTdnYU9aO1rsgYiYmzhdzhjfJN1XY9q9P6fIlAsFzZBq5IkLlfn4L+YkJ8H/GycsXyx4msEQ8qP/DJFEgFI45nIwYubEa/a2TwoiEMUaBv3B9og2FABsHnnTchZ2EFyKh6pcgi4nF0zxIf5J1clIhawKI3gDts+hVIH/C64X6EI7aQmj4Vw==;5:IJGzmU2XhUNEZoNJ7ZRhWy4QEtT/xCuhAJn4KRw5RR51Q6XrDLwEES/EhBqZaoNB5fHBsJhZnef0SfqdAU1CB50WyOhmWE0r9+EO2HS7Kyr4fB+QD1nQD/HaD++qVdZrYGunIqr9Yh+0ps/1mdY5JA==;24:wYPKdrtNtaOyMy2PLmvpiKH28OmwPaK62O18n7OExs+hemb/Q8RDeCs76KPxD56b16qpTzxx9VRjBArdoioXY3rS9SyQc4vVwLtGJqtyZjw=;7:7GnD9Tf03mzTUzy1/4DLh2PSmLHfpZlm6vxsPneHJqazY4+u/xx2gx0IhWSGbfO8fLb0q3CHWbkXqs5KNEcseu2Yg0gBuKc98DfYFs/ZaZAiM+sfZ4I/6YBJTV8ESatyBbNDpm3mlZ6ZlTW7M2cfA5HKg4FrdDpFaWge4bwkxpbgSzKIH2F81vmkYSATWgJs7dPQ9pUV9E7S2tV3cV0mxZPHdSS8iCHSZJuJ35zTHnA= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: microsemi.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Sep 2017 20:13:23.9695 (UTC) X-MS-Exchange-CrossTenant-Id: f267a5c8-86d8-4cc9-af71-1fd2c67c8fad X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f267a5c8-86d8-4cc9-af71-1fd2c67c8fad;Ip=[208.19.100.20];Helo=[avsrvexchhts2.microsemi.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY2PR0201MB1446 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by nfs id v8FKDZZo024983 Content-Length: 428 Lines: 11 > > Fix possible indexing array of bound for &aac->hba_map[bus][cid], where bus > and cid boundary check happens later. > > Fixes: 0d643ff3c353 ("scsi: aacraid: use aac_tmf_callback for reset fib") > Signed-off-by: Nikola Pajkovsky > --- > drivers/scsi/aacraid/linit.c | 20 ++++++++++++-------- > 1 file changed, 12 insertions(+), 8 deletions(-) Reviewed-by: Dave Carroll