Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751793AbdIOUx6 (ORCPT ); Fri, 15 Sep 2017 16:53:58 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:53018 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751640AbdIOUx5 (ORCPT ); Fri, 15 Sep 2017 16:53:57 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org BA536600CE Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=clew@codeaurora.org Subject: Re: [PATCH v2 1/5] soc: qcom: smem: Use le32_to_cpu for partition size comparison To: Stephen Boyd Cc: bjorn.andersson@linaro.org, andy.gross@linaro.org, david.brown@linaro.org, aneela@codeaurora.org, linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org, linux-kernel@vger.kernel.org References: <1505424302-29147-1-git-send-email-clew@codeaurora.org> <1505424302-29147-2-git-send-email-clew@codeaurora.org> <20170915183907.GB3349@codeaurora.org> From: Chris Lew Message-ID: <204750f6-c1eb-e971-63f1-577c3880878f@codeaurora.org> Date: Fri, 15 Sep 2017 13:53:55 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <20170915183907.GB3349@codeaurora.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1305 Lines: 40 On 9/15/2017 11:39 AM, Stephen Boyd wrote: > On 09/14, Chris Lew wrote: >> Endianness can vary in the system, add le32_to_cpu when comparing >> size values from smem. >> >> Signed-off-by: Chris Lew >> --- >> >> Changes since v1: >> - New change >> >> drivers/soc/qcom/smem.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/soc/qcom/smem.c b/drivers/soc/qcom/smem.c >> index c28275be0038..db04c45d4132 100644 >> --- a/drivers/soc/qcom/smem.c >> +++ b/drivers/soc/qcom/smem.c >> @@ -698,7 +698,7 @@ static int qcom_smem_enumerate_partitions(struct qcom_smem *smem, >> return -EINVAL; >> } >> >> - if (header->size != entry->size) { >> + if (le32_to_cpu(header->size) != le32_to_cpu(entry->size)) { > > Also, it doesn't really matter. We're comparing two numbers with > the same endianness, so comparing them for equality before or > after swapping makes no difference. Sparse also (correctly) > doesn't complain here, because adding the conversion is not > necessary. Drop this patch? > Hey Bjorn, should we remove this patch? You had flagged this comparison in the first version of the global partition changes. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project