Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751815AbdIOVCH (ORCPT ); Fri, 15 Sep 2017 17:02:07 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:54920 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751718AbdIOVCF (ORCPT ); Fri, 15 Sep 2017 17:02:05 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 5FB09600C9 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=clew@codeaurora.org Subject: Re: [PATCH v2 3/5] soc: qcom: smem: Support global partition To: Bjorn Andersson Cc: andy.gross@linaro.org, david.brown@linaro.org, aneela@codeaurora.org, linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org, linux-kernel@vger.kernel.org References: <1505424302-29147-1-git-send-email-clew@codeaurora.org> <1505424302-29147-4-git-send-email-clew@codeaurora.org> <20170915183334.GQ2016@tuxbook> From: Chris Lew Message-ID: Date: Fri, 15 Sep 2017 14:02:03 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <20170915183334.GQ2016@tuxbook> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1352 Lines: 43 On 9/15/2017 11:33 AM, Bjorn Andersson wrote: > On Thu 14 Sep 14:25 PDT 2017, Chris Lew wrote: > > [..] >> +static struct smem_ptable *qcom_smem_get_ptable(struct qcom_smem *smem) >> { >> - struct smem_partition_header *header; >> - struct smem_ptable_entry *entry; >> struct smem_ptable *ptable; >> - unsigned remote_host; >> - u32 version, host0, host1; >> - int i; >> + u32 version; >> >> ptable = smem->regions[0].virt_base + smem->regions[0].size - SZ_4K; >> if (memcmp(ptable->magic, SMEM_PTABLE_MAGIC, sizeof(ptable->magic))) >> - return 0; >> + return NULL; >> >> version = le32_to_cpu(ptable->version); >> if (version != 1) { >> dev_err(smem->dev, >> "Unsupported partition header version %d\n", version); >> + return ERR_PTR(-EINVAL); > > In the calling places NULL and -EINVAL are both treated as -EINVAL, so I > think it's better to just return NULL here as well as check for !ptable > in callers. > > Regards, > Bjorn > qcom_smem_enumerate_partitions allowed the partition table to be optional before. I want to keep that behavior for V11 where smem might only have the global heap. The probe will continue with a NULL/0 return from qcom_get_ptable/qcom_smem_enumerate_partitions. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project