Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751992AbdIOVHl (ORCPT ); Fri, 15 Sep 2017 17:07:41 -0400 Received: from mail-qk0-f196.google.com ([209.85.220.196]:34352 "EHLO mail-qk0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751685AbdIOVHi (ORCPT ); Fri, 15 Sep 2017 17:07:38 -0400 X-Google-Smtp-Source: AOwi7QAa3Ow6j6o2FzB/wZnubJrAhCOERW9tv6dOCz/kC05YnraHhwOl0J0ATAKa27QvHxToWgxFEI9JiFZTb0LQJ3Q= MIME-Version: 1.0 In-Reply-To: References: <1505504680-22167-1-git-send-email-srishtishar@gmail.com> From: Srishti Sharma Date: Sat, 16 Sep 2017 02:37:37 +0530 Message-ID: Subject: Re: [Outreachy kernel] [PATCH v2] Staging: irda: Don't use assignment inside if statement To: Julia Lawall Cc: samuel@sortiz.org, Greg KH , netdev@vger.kernel.org, devel@driverdev.osuosl.org, Linux kernel mailing list , outreachy-kernel@googlegroups.com Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3770 Lines: 108 On Sat, Sep 16, 2017 at 1:30 AM, Julia Lawall wrote: > > > On Sat, 16 Sep 2017, Srishti Sharma wrote: > >> Write assignment statement outside the if statement. Done using >> the following semantic patch by coccinelle. >> >> @@ >> identifier E; >> expression F; >> statement S; >> @@ >> >> -if((E = F)) >> +E = F; >> +if(E) >> S >> >> Signed-off-by: Srishti Sharma > > Acked-by: Julia Lawall Have sent a patchset for this instead . Regards, Srishti > >> --- >> Changes in v2: >> -Semicolon was missing in one of the statements of the >> semantic patch >> >> drivers/staging/irda/drivers/irda-usb.c | 4 ++-- >> drivers/staging/irda/drivers/mcs7780.c | 9 ++++++--- >> drivers/staging/irda/net/irqueue.c | 3 ++- >> 3 files changed, 10 insertions(+), 6 deletions(-) >> >> diff --git a/drivers/staging/irda/drivers/irda-usb.c b/drivers/staging/irda/drivers/irda-usb.c >> index 723e49b..82bfc05 100644 >> --- a/drivers/staging/irda/drivers/irda-usb.c >> +++ b/drivers/staging/irda/drivers/irda-usb.c >> @@ -334,9 +334,9 @@ static void irda_usb_change_speed_xbofs(struct irda_usb_cb *self) >> urb->transfer_flags = 0; >> >> /* Irq disabled -> GFP_ATOMIC */ >> - if ((ret = usb_submit_urb(urb, GFP_ATOMIC))) { >> + ret = usb_submit_urb(urb, GFP_ATOMIC); >> + if (ret) >> net_warn_ratelimited("%s(), failed Speed URB\n", __func__); >> - } >> } >> >> /*------------------------------------------------------------------*/ >> diff --git a/drivers/staging/irda/drivers/mcs7780.c b/drivers/staging/irda/drivers/mcs7780.c >> index c3f0b25..2b674d5 100644 >> --- a/drivers/staging/irda/drivers/mcs7780.c >> +++ b/drivers/staging/irda/drivers/mcs7780.c >> @@ -605,19 +605,22 @@ static int mcs_speed_change(struct mcs_cb *mcs) >> if (mcs->new_speed <= 115200) { >> rval &= ~MCS_FIR; >> >> - if ((rst = (mcs->speed > 115200))) >> + rst = (mcs->speed > 115200); >> + if (rst) >> mcs_set_reg(mcs, MCS_MINRXPW_REG, 0); >> >> } else if (mcs->new_speed <= 1152000) { >> rval &= ~MCS_FIR; >> >> - if ((rst = !(mcs->speed == 576000 || mcs->speed == 1152000))) >> + rst = !(mcs->speed == 576000 || mcs->speed == 1152000); >> + if (rst) >> mcs_set_reg(mcs, MCS_MINRXPW_REG, 5); >> >> } else { >> rval |= MCS_FIR; >> >> - if ((rst = (mcs->speed != 4000000))) >> + rst = (mcs->speed != 4000000); >> + if (rst) >> mcs_set_reg(mcs, MCS_MINRXPW_REG, 5); >> >> } >> diff --git a/drivers/staging/irda/net/irqueue.c b/drivers/staging/irda/net/irqueue.c >> index 160dc89..5aab072 100644 >> --- a/drivers/staging/irda/net/irqueue.c >> +++ b/drivers/staging/irda/net/irqueue.c >> @@ -217,7 +217,8 @@ static __u32 hash( const char* name) >> >> while(*name) { >> h = (h<<4) + *name++; >> - if ((g = (h & 0xf0000000))) >> + g = (h & 0xf0000000); >> + if (g) >> h ^=g>>24; >> h &=~g; >> } >> -- >> 2.7.4 >> >> -- >> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group. >> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com. >> To post to this group, send email to outreachy-kernel@googlegroups.com. >> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/1505504680-22167-1-git-send-email-srishtishar%40gmail.com. >> For more options, visit https://groups.google.com/d/optout. >>