Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751385AbdIPHOZ (ORCPT ); Sat, 16 Sep 2017 03:14:25 -0400 Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]:61835 "EHLO mail2-relais-roc.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750909AbdIPHOX (ORCPT ); Sat, 16 Sep 2017 03:14:23 -0400 X-IronPort-AV: E=Sophos;i="5.42,400,1500933600"; d="scan'208";a="291359800" Date: Sat, 16 Sep 2017 09:14:21 +0200 (CEST) From: Julia Lawall X-X-Sender: jll@hadrien To: Srishti Sharma cc: samuel@sortiz.org, gregkh@linuxfoundation.org, netdev@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, outreachy-kernel@googlegroups.com Subject: Re: [Outreachy kernel] [PATCH] Staging: irda: Use !x instead of NULL comparison In-Reply-To: <1505543667-4670-1-git-send-email-srishtishar@gmail.com> Message-ID: References: <1505543667-4670-1-git-send-email-srishtishar@gmail.com> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2154 Lines: 65 On Sat, 16 Sep 2017, Srishti Sharma wrote: > Test for NULL as !x where functions that return NULL on failure > are used. Done using the following semantic patch by coccinelle. > > @ is_null @ > expression E; > statement S; > @@ > > E = (\(kmalloc\|devm_kzalloc\|kmalloc_array\|devm_ioremap\| > usb_alloc_urb\|alloc_netdev\|dev_alloc_skb\)(...)); > > ( > if(!E) > S > | > -if(E==NULL) > +if(!E) > S > ) > > Signed-off-by: Srishti Sharma Acked-by: Julia Lawall > --- > drivers/staging/irda/net/discovery.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/irda/net/discovery.c b/drivers/staging/irda/net/discovery.c > index 364d70a..1e54954 100644 > --- a/drivers/staging/irda/net/discovery.c > +++ b/drivers/staging/irda/net/discovery.c > @@ -179,7 +179,7 @@ void irlmp_expire_discoveries(hashbin_t *log, __u32 saddr, int force) > /* Create the client specific buffer */ > n = HASHBIN_GET_SIZE(log); > buffer = kmalloc(n * sizeof(struct irda_device_info), GFP_ATOMIC); > - if (buffer == NULL) { > + if (!buffer) { > spin_unlock_irqrestore(&log->hb_spinlock, flags); > return; > } > @@ -291,7 +291,7 @@ struct irda_device_info *irlmp_copy_discoveries(hashbin_t *log, int *pn, > /* Create the client specific buffer */ > n = HASHBIN_GET_SIZE(log); > buffer = kmalloc(n * sizeof(struct irda_device_info), GFP_ATOMIC); > - if (buffer == NULL) { > + if (!buffer) { > spin_unlock_irqrestore(&log->hb_spinlock, flags); > return NULL; > } > -- > 2.7.4 > > -- > You received this message because you are subscribed to the Google Groups "outreachy-kernel" group. > To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com. > To post to this group, send email to outreachy-kernel@googlegroups.com. > To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/1505543667-4670-1-git-send-email-srishtishar%40gmail.com. > For more options, visit https://groups.google.com/d/optout. >