Subject: Re: [PATCH 1/3] Add a new element for the struct perf_tool, and add
 the --per-event-dump option for perf script
To: yuzhoujian <ufo19890607@gmail.com>, peterz@infradead.org,
        mingo@redhat.com, alexander.shishkin@linux.intel.com, jolsa@kernel.org,
        namhyung@kernel.org, yuzhoujian@didichuxing.com
Cc: linux-kernel@vger.kernel.org
References: <1505315433-28437-1-git-send-email-yuzhoujian@didichuxing.com>
 <1505315433-28437-2-git-send-email-yuzhoujian@didichuxing.com>
From: David Ahern <dsahern@gmail.com>
Message-ID: <7e770966-b165-49cf-fe50-81ccacb09fcf@gmail.com>
Date: Sat, 16 Sep 2017 09:18:55 -0600
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:52.0)
 Gecko/20100101 Thunderbird/52.3.0
MIME-Version: 1.0
In-Reply-To: <1505315433-28437-2-git-send-email-yuzhoujian@didichuxing.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 631
Lines: 19

On 9/13/17 9:10 AM, yuzhoujian wrote:
> @@ -2797,7 +2801,12 @@ int cmd_script(int argc, const char **argv)
>  
>  	file.path = input_name;
>  	file.force = symbol_conf.force;
> -
> +	for (i = 1; argv[i] != NULL; i++) {
> +		if (strcmp(argv[i], "-O") == 0) {
> +			script.tool.orientation_output = true;
> +			break;
> +		}
> +	}
>  	if (argc > 1 && !strncmp(argv[0], "rec", strlen("rec"))) {
>  		rec_script_path = get_script_path(argv[1], RECORD_SUFFIX);
>  		if (!rec_script_path)


That change should be dropped. I recall Arnaldo saying this feature does
not need a short option and the above is not how it should done anyways.