Subject: Re: [PATCH 2/3] Makes all those related functions receive the FILE
 pointer
To: yuzhoujian <ufo19890607@gmail.com>, peterz@infradead.org,
        mingo@redhat.com, alexander.shishkin@linux.intel.com, jolsa@kernel.org,
        namhyung@kernel.org, yuzhoujian@didichuxing.com
Cc: linux-kernel@vger.kernel.org
References: <1505315433-28437-1-git-send-email-yuzhoujian@didichuxing.com>
 <1505315433-28437-3-git-send-email-yuzhoujian@didichuxing.com>
From: David Ahern <dsahern@gmail.com>
Message-ID: <3ebd97c7-2fbc-757d-f733-5edd901ccc60@gmail.com>
Date: Sat, 16 Sep 2017 09:23:32 -0600
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:52.0)
 Gecko/20100101 Thunderbird/52.3.0
MIME-Version: 1.0
In-Reply-To: <1505315433-28437-3-git-send-email-yuzhoujian@didichuxing.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 826
Lines: 23

On 9/13/17 9:10 AM, yuzhoujian wrote:
> @@ -1621,8 +1634,12 @@ static int process_comm_event(struct perf_tool *tool,
>  		sample->tid = event->comm.tid;
>  		sample->pid = event->comm.pid;
>  	}
> -	print_sample_start(sample, thread, evsel);
> -	perf_event__fprintf(event, stdout);
> +	if (tool->orientation_output == false)
> +		fp = stdout;
> +	else
> +		fp = orientation_file;
> +	fprint_sample_start(sample, thread, evsel, fp);
> +	perf_event__fprintf(event, fp);
>  	ret = 0;
>  out:
>  	thread__put(thread);

The subject of this patch is replacing printf and stdout with fprintf
and a given fp. Please keep it to that one change. Meaning the above
setting of fp something other than stdout should be a separate patch.

And it would be best to have the fp selection in a helper, versus the
same change in so many places.