Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751294AbdIPRTh (ORCPT <rfc822;w@1wt.eu>);
        Sat, 16 Sep 2017 13:19:37 -0400
Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]:17402 "EHLO
        mail2-relais-roc.national.inria.fr" rhost-flags-OK-OK-OK-OK)
        by vger.kernel.org with ESMTP id S1751233AbdIPRTg (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Sat, 16 Sep 2017 13:19:36 -0400
X-IronPort-AV: E=Sophos;i="5.42,403,1500933600"; 
   d="scan'208";a="291393272"
Date: Sat, 16 Sep 2017 19:19:34 +0200 (CEST)
From: Julia Lawall <julia.lawall@lip6.fr>
X-X-Sender: jll@hadrien
To: Srishti Sharma <srishtishar@gmail.com>
cc: lidza.louina@gmail.com, markh@compro.net, gregkh@linuxfoundation.org,
        driverdev-devel@linuxdriverproject.org, devel@driverdev.osuosl.org,
        linux-kernel@vger.kernel.org, outreachy-kernel@googlegroups.com
Subject: Re: [Outreachy kernel] [PATCH v2 1/2] Staging: dgnc: Remove unused
 fields in struct dgnc_board
In-Reply-To: <dd9a08aabab9cfc60a5c7c7c0d5191d72e68c2d2.1505579408.git.srishtishar@gmail.com>
Message-ID: <alpine.DEB.2.20.1709161919170.1992@hadrien>
References: <cover.1505579408.git.srishtishar@gmail.com> <dd9a08aabab9cfc60a5c7c7c0d5191d72e68c2d2.1505579408.git.srishtishar@gmail.com>
User-Agent: Alpine 2.20 (DEB 67 2015-01-07)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 2117
Lines: 65



On Sat, 16 Sep 2017, Srishti Sharma wrote:

> Remove unused fields and comments associated with them in
> the structure definition.
>
> Signed-off-by: Srishti Sharma <srishtishar@gmail.com>

Acked-by: Julia Lawall <julia.lawall@lip6.fr>

> ---
> Changes in v2:
>  - Use the word field instead of variable.
>
>  drivers/staging/dgnc/dgnc_driver.h | 9 ---------
>  1 file changed, 9 deletions(-)
>
> diff --git a/drivers/staging/dgnc/dgnc_driver.h b/drivers/staging/dgnc/dgnc_driver.h
> index 764d6fe..5d2566e 100644
> --- a/drivers/staging/dgnc/dgnc_driver.h
> +++ b/drivers/staging/dgnc/dgnc_driver.h
> @@ -104,7 +104,6 @@ struct board_ops {
>   * struct dgnc_board - Per board information.
>   * @boardnum: Board number (0 - 32).
>   *
> - * @type: Type of board.
>   * @name: Product name.
>   * @pdev: Pointer to the pci_dev structure.
>   * @bd_flags: Board flags.
> @@ -140,13 +139,9 @@ struct board_ops {
>   * @dpastatus: Board status as defined by DPA.
>   * @bd_dividend: Board/UART's specific dividend.
>   * @bd_ops: Pointer to board operations structure.
> - * @proc_entry_pointer: Proc/<board> entry
> - * @dgnc_board_table: Proc/<board> entry
>   */
>  struct dgnc_board {
>  	int		boardnum;
> -
> -	int		type;
>  	char		*name;
>  	struct pci_dev	*pdev;
>  	unsigned long	bd_flags;
> @@ -200,10 +195,6 @@ struct dgnc_board {
>  	uint		bd_dividend;
>
>  	struct board_ops *bd_ops;
> -
> -	struct proc_dir_entry *proc_entry_pointer;
> -	struct dgnc_proc_entry *dgnc_board_table;
> -
>  };
>
>  /* Unit flag definitions for un_flags. */
> --
> 2.7.4
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/dd9a08aabab9cfc60a5c7c7c0d5191d72e68c2d2.1505579408.git.srishtishar%40gmail.com.
> For more options, visit https://groups.google.com/d/optout.
>