Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751365AbdIPRT7 (ORCPT <rfc822;w@1wt.eu>);
        Sat, 16 Sep 2017 13:19:59 -0400
Received: from mail3-relais-sop.national.inria.fr ([192.134.164.104]:24329
        "EHLO mail3-relais-sop.national.inria.fr" rhost-flags-OK-OK-OK-OK)
        by vger.kernel.org with ESMTP id S1751233AbdIPRT6 (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Sat, 16 Sep 2017 13:19:58 -0400
X-IronPort-AV: E=Sophos;i="5.42,403,1500933600"; 
   d="scan'208";a="237734307"
Date: Sat, 16 Sep 2017 19:19:56 +0200 (CEST)
From: Julia Lawall <julia.lawall@lip6.fr>
X-X-Sender: jll@hadrien
To: Srishti Sharma <srishtishar@gmail.com>
cc: lidza.louina@gmail.com, markh@compro.net, gregkh@linuxfoundation.org,
        driverdev-devel@linuxdriverproject.org, devel@driverdev.osuosl.org,
        linux-kernel@vger.kernel.org, outreachy-kernel@googlegroups.com
Subject: Re: [Outreachy kernel] [PATCH v2 2/2] Staging: dgnc: Remove unused
 fields in struct channel_t
In-Reply-To: <a57f835fc443d51ae9eadd1b995435c215f14974.1505579409.git.srishtishar@gmail.com>
Message-ID: <alpine.DEB.2.20.1709161919380.1992@hadrien>
References: <cover.1505579408.git.srishtishar@gmail.com> <a57f835fc443d51ae9eadd1b995435c215f14974.1505579409.git.srishtishar@gmail.com>
User-Agent: Alpine 2.20 (DEB 67 2015-01-07)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1784
Lines: 52



On Sat, 16 Sep 2017, Srishti Sharma wrote:

> Eliminate the fields that are not used and the comments
> associated with them.
>
> Signed-off-by: Srishti Sharma <srishtishar@gmail.com>

Acked-by: Julia Lawall <julia.lawall@lip6.fr>

> ---
> Changes in v2:
>  - Use the word field instead of variable.
>
>  drivers/staging/dgnc/dgnc_driver.h | 6 ------
>  1 file changed, 6 deletions(-)
>
> diff --git a/drivers/staging/dgnc/dgnc_driver.h b/drivers/staging/dgnc/dgnc_driver.h
> index 5d2566e..082d659 100644
> --- a/drivers/staging/dgnc/dgnc_driver.h
> +++ b/drivers/staging/dgnc/dgnc_driver.h
> @@ -312,8 +312,6 @@ struct un_t {
>   * @ch_err_overrun: Count of overruns on channel.
>   * @ch_xon_sends: Count of xons transmitted.
>   * @ch_xoff_sends: Count of xoffs transmitted.
> - * @proc_entry_pointer: Proc/<board>/<channel> entry.
> - * @dgnc_channel_table: Proc/<board>/<channel> entry.
>   */
>  struct channel_t {
>  	struct dgnc_board *ch_bd;
> @@ -382,10 +380,6 @@ struct channel_t {
>
>  	ulong		ch_xon_sends;
>  	ulong		ch_xoff_sends;
> -
> -	struct proc_dir_entry *proc_entry_pointer;
> -	struct dgnc_proc_entry *dgnc_channel_table;
> -
>  };
>
>  extern uint		dgnc_major;		/* Our driver/mgmt major */
> --
> 2.7.4
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/a57f835fc443d51ae9eadd1b995435c215f14974.1505579409.git.srishtishar%40gmail.com.
> For more options, visit https://groups.google.com/d/optout.
>