Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751535AbdIQOZT (ORCPT ); Sun, 17 Sep 2017 10:25:19 -0400 Received: from mail-out-1.itc.rwth-aachen.de ([134.130.5.46]:3614 "EHLO mail-out-1.itc.rwth-aachen.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751298AbdIQOZS (ORCPT ); Sun, 17 Sep 2017 10:25:18 -0400 X-IronPort-AV: E=Sophos;i="5.42,407,1500933600"; d="scan'208";a="13756754" From: =?UTF-8?q?Stefan=20Br=C3=BCns?= To: CC: Vinod Koul , , "Dan Williams" Subject: [PATCH] dmaengine: edma: Reject slave configs using a buswidth of 8 and larger Date: Sun, 17 Sep 2017 16:25:10 +0200 Message-ID: <20170917142510.3111-1-stefan.bruens@rwth-aachen.de> X-Mailer: git-send-email 2.14.1 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-Originating-IP: [77.181.34.79] X-ClientProxiedBy: rwthex-s3-a.rwth-ad.de (2002:8682:1aa0::8682:1aa0) To rwthex-w1-a.rwth-ad.de (2002:8682:1a9c::8682:1a9c) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 821 Lines: 25 The driver would happily accept buswidth of 16/32/64 bytes and program garbage to its registers. Signed-off-by: Stefan Brüns --- drivers/dma/edma.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/dma/edma.c b/drivers/dma/edma.c index 3879f80a4815..c944ea339425 100644 --- a/drivers/dma/edma.c +++ b/drivers/dma/edma.c @@ -887,8 +887,8 @@ static int edma_slave_config(struct dma_chan *chan, { struct edma_chan *echan = to_edma_chan(chan); - if (cfg->src_addr_width == DMA_SLAVE_BUSWIDTH_8_BYTES || - cfg->dst_addr_width == DMA_SLAVE_BUSWIDTH_8_BYTES) + if (cfg->src_addr_width >= DMA_SLAVE_BUSWIDTH_8_BYTES || + cfg->dst_addr_width >= DMA_SLAVE_BUSWIDTH_8_BYTES) return -EINVAL; memcpy(&echan->cfg, cfg, sizeof(echan->cfg)); -- 2.14.1