Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751980AbdIQVPc (ORCPT ); Sun, 17 Sep 2017 17:15:32 -0400 Received: from smtprelay0207.hostedemail.com ([216.40.44.207]:40065 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751352AbdIQVPa (ORCPT ); Sun, 17 Sep 2017 17:15:30 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::,RULES_HIT:41:355:379:541:599:800:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1538:1593:1594:1711:1730:1747:1777:1792:2393:2559:2562:2693:2828:3138:3139:3140:3141:3142:3315:3352:3622:3865:3867:3868:3870:3871:3872:3873:3874:4321:5007:6119:7576:7903:10004:10400:10848:11232:11658:11914:12740:12760:12895:13069:13095:13311:13357:13439:14181:14659:21080:21220:21433:21451:21627:30012:30054:30063:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:1,LUA_SUMMARY:none X-HE-Tag: fly19_871274c9da40d X-Filterd-Recvd-Size: 2190 Message-ID: <1505682926.16316.15.camel@perches.com> Subject: Re: [PATCH V2] tipc: Use bsearch library function From: Joe Perches To: Jon Maloy , Thomas Meyer Cc: Ying Xue , "netdev@vger.kernel.org" , "tipc-discussion@lists.sourceforge.net" , "linux-kernel@vger.kernel.org" , "davem@davemloft.net" Date: Sun, 17 Sep 2017 14:15:26 -0700 In-Reply-To: References: <20170911.143025.555018840006192902.davem@davemloft.net> <20170916075036.28676-1-thomas@m3y3r.de> <16128f5e-66ff-b6ec-c0e1-74ea08c212b0@windriver.com> <1505553970.16316.1.camel@perches.com> <64ee51ce-eb7e-ac1c-56a9-9481f6f80b35@windriver.com> <1505555908.16316.5.camel@perches.com> <35f41984-22e9-5adc-0e4d-a4ef4204f6d7@windriver.com> <1505557061.16316.7.camel@perches.com> <760F46A5-2C04-4F3F-83C5-5EA331CFA1D6@m3y3r.de> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.22.6-1ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 574 Lines: 13 On Sun, 2017-09-17 at 16:27 +0000, Jon Maloy wrote: > > -----Original Message----- > > From: Thomas Meyer [mailto:thomas@m3y3r.de] [] > > What about the other binary search implementation in the same file? Should > > I try to convert it it will it get NAKed for performance reasons too? > > The searches for inserting and removing publications is less time critical, > so that would be ok with me. > If you have any more general interest in improving the code in this file > (which is needed) it would also be appreciated. Perhaps using an rbtree would be an improvement.