Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751922AbdIRACi (ORCPT ); Sun, 17 Sep 2017 20:02:38 -0400 Received: from mail-bn3nam01on0134.outbound.protection.outlook.com ([104.47.33.134]:54192 "EHLO NAM01-BN3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751254AbdIRACh (ORCPT ); Sun, 17 Sep 2017 20:02:37 -0400 From: KY Srinivasan To: Greg KH CC: "linux-kernel@vger.kernel.org" , "devel@linuxdriverproject.org" , "olaf@aepfle.de" , "apw@canonical.com" , "vkuznets@redhat.com" , "jasowang@redhat.com" , "leann.ogasawara@canonical.com" , "marcelo.cerri@canonical.com" , Stephen Hemminger , Dexuan Cui , Haiyang Zhang Subject: RE: [PATCH 2/5] vmbus: suppress uevents for hv_sock devices Thread-Topic: [PATCH 2/5] vmbus: suppress uevents for hv_sock devices Thread-Index: AQHTKftui+XFoq3rgE20Fe9LO5RX1KKtxFsAgAwJqNA= Date: Mon, 18 Sep 2017 00:02:33 +0000 Message-ID: References: <20170910055318.31655-1-kys@exchange.microsoft.com> <20170910060849.31898-1-kys@exchange.microsoft.com> <20170910060849.31898-2-kys@exchange.microsoft.com> <20170910080944.GB3573@kroah.com> In-Reply-To: <20170910080944.GB3573@kroah.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Enabled=True; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SiteId=72f988bf-86f1-41af-91ab-2d7cd011db47; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Ref=https://api.informationprotection.azure.com/api/72f988bf-86f1-41af-91ab-2d7cd011db47; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Owner=kys@microsoft.com; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SetDate=2017-09-17T17:02:31.5414885-07:00; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Name=General; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Application=Microsoft Azure Information Protection; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Extended_MSFT_Method=Automatic; Sensitivity=General x-originating-ip: [73.254.106.230] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;DM5PR21MB0636;6:Ac2q9DwSpdYJEQ4CzNVjWN6rGthVEfTcrV/5w7ZtJ0vY1MDTiTNZI1VUnjQKUFx+0qiE717TvHUBLyWYGQMkH4fkqUpSCLUhoI55COYbubr3IFq0EfOmdhipYqeTit/vKQSTEn0jWlLoUY6zmOSF4vg/miUkVVbkCQYbtHxWLLpMsvmoPwlHin7D2K8bA82JQMwF7oAmVdcHbmH5BUfo/1j+xfCCz/kxlNOzSEeyttejacmGLYrpsNixgdQuazU65j6X71zSSaQS76J/52BnPuFTwgF/NiDY6LXjwJuUD8vuQnnbXRxH2z12INvilYegNj1LsS5wpdgXrXWLgSYcCw==;5:4NQteuPXbKJO4Y9o9xX4UpPlonKuoytVsng2qXBx5xEsuPrB3kh6MqjSM8rTueYAs8KcTtHqsemSr7xLPop+UgMrvTrj9nhi2j0H2uYGPWmd1TkV/JfHdzQt2ryARLDpNt71fzKaNI1s8JJk+bcJoQ==;24:vOAIgaz5uHncpyE59u5zU05bgTpD8iTt3pkSp+jpqjLwLtrPQUNq6h6GfWSf4043fBxSRkFEhJFgB6ZtVBrz6BPCnhUblUXUeWsLWhnw+XQ=;7:7LjNsx8MHY38u1eYSG+ahKxCnF2IRDsTRHLHGAOd+PcHx2oh8Y5w9NVx+b+BoTsQaG++B10o3OAmDKv3bOrgN5ALd8jHWclAqHow/i8fbpC/koxYHTX6quNgVjl7e5+92Sf92xk8I3Jqhz2JuqR45u4zzKDhnZ3+jj6xE0Cv5SzZyxWnZw9Fq9edLUu5oVl2f0auaX+DdVqINaf7nYLB7pBRHdmzB+qwN17yETCP5h0= x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-correlation-id: 5ee7c844-c7bd-46d7-f099-08d4fe289013 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(48565401081)(300000503095)(300135400095)(2017052603199)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095);SRVR:DM5PR21MB0636; x-ms-traffictypediagnostic: DM5PR21MB0636: authentication-results: spf=none (sender IP is ) smtp.mailfrom=kys@microsoft.com; x-exchange-antispam-report-test: UriScan:(89211679590171)(9452136761055)(140211028294663)(198206253151910); x-microsoft-antispam-prvs: x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(61425038)(6040450)(2401047)(5005006)(8121501046)(10201501046)(3002001)(100000703101)(100105400095)(93006095)(93001095)(6055026)(61426038)(61427038)(6041248)(20161123560025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123558100)(20161123564025)(20161123555025)(20161123562025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:DM5PR21MB0636;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:DM5PR21MB0636; x-forefront-prvs: 04347F8039 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(6009001)(39860400002)(346002)(376002)(47760400005)(13464003)(24454002)(377454003)(189002)(199003)(81156014)(54906002)(6246003)(99286003)(55016002)(9686003)(97736004)(102836003)(6116002)(8936002)(229853002)(8676002)(107886003)(110136004)(68736007)(316002)(53936002)(3280700002)(7736002)(3660700001)(2906002)(86612001)(305945005)(53546010)(77096006)(8990500004)(74316002)(66066001)(86362001)(10090500001)(33656002)(5660300001)(106356001)(7696004)(478600001)(2900100001)(189998001)(81166006)(2950100002)(6916009)(6506006)(93886005)(101416001)(6436002)(4326008)(50986999)(76176999)(54356999)(3846002)(25786009)(105586002)(14454004)(22452003)(10290500003);DIR:OUT;SFP:1102;SCL:1;SRVR:DM5PR21MB0636;H:DM5PR21MB0476.namprd21.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Sep 2017 00:02:33.4674 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR21MB0636 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by nfs id v8I02j89011341 Content-Length: 1667 Lines: 47 > -----Original Message----- > From: Greg KH [mailto:gregkh@linuxfoundation.org] > Sent: Sunday, September 10, 2017 1:10 AM > To: KY Srinivasan > Cc: linux-kernel@vger.kernel.org; devel@linuxdriverproject.org; > olaf@aepfle.de; apw@canonical.com; vkuznets@redhat.com; > jasowang@redhat.com; leann.ogasawara@canonical.com; > marcelo.cerri@canonical.com; Stephen Hemminger > ; Dexuan Cui ; Haiyang > Zhang > Subject: Re: [PATCH 2/5] vmbus: suppress uevents for hv_sock devices > > On Sat, Sep 09, 2017 at 11:08:46PM -0700, kys@exchange.microsoft.com > wrote: > > From: Dexuan Cui > > > > hv_sock driver is automatically loaded when an application creates an > > AF_VSOCK socket, so we don't really need to trigger uevents to the user > > space udevd. > > > > And hv_sock devices can appear and disappear frequency, e.g. 100 per > > second, so triggering the udevents can cause a high cpu utilization of > > udevd, e.g. 30% on a 2-cpu virtual machine. So let's suppress the > > uevents to avoid this. > > 100 per second for a struct device? That's crazy, and the uevent is the > least of your worries. Please fix that, as it's not the correct way to > use the driver model at all. > > And really, why is uevent taking all that much cpu time anyway? It > _should_ be pretty fast, unless your distro is doing crazy things with > it... > > sorry, am not going to take this patch. Greg, This is not a real problem that needs fixing. The test automation triggered this condition. I will drop this patch and send the rest. Regards, K. Y > > greg k-h