Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752152AbdIRGog convert rfc822-to-8bit (ORCPT ); Mon, 18 Sep 2017 02:44:36 -0400 Received: from ozlabs.org ([103.22.144.67]:33745 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750711AbdIRGoe (ORCPT ); Mon, 18 Sep 2017 02:44:34 -0400 From: Michael Ellerman To: =?utf-8?Q?Jan_H=2E_Sch=C3=B6nherr?= , Paolo Bonzini , Radim =?utf-8?B?S3LEjW3DocWZ?= Cc: sachinp@linux.vnet.ibm.com, kvm@vger.kernel.org, =?utf-8?Q?Jan_H=2E_Sc?= =?utf-8?Q?h=C3=B6nherr?= , linux-kernel@vger.kernel.org, Abdul Haleem , linuxppc-dev@lists.ozlabs.org Subject: Re: [PATCH] Revert "KVM: Don't accept obviously wrong gsi values via KVM_IRQFD" In-Reply-To: <1505592744-31498-1-git-send-email-jschoenh@amazon.de> References: <04cde7c8-d41f-96e2-2b4b-2287b8f04bfc@amazon.de> <1505592744-31498-1-git-send-email-jschoenh@amazon.de> User-Agent: Notmuch/0.21 (https://notmuchmail.org) Date: Mon, 18 Sep 2017 16:44:32 +1000 Message-ID: <871sn4jyjz.fsf@concordia.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 830 Lines: 23 "Jan H. Schönherr" writes: > This reverts commit 36ae3c0a36b7456432fedce38ae2f7bd3e01a563. > > The commit broke compilation on !CONFIG_HAVE_KVM_IRQ_ROUTING. Also, > there may be cases with CONFIG_HAVE_KVM_IRQ_ROUTING, where larger > gsi values make sense. > > As the commit was meant as an early indicator to user space that > something is wrong, reverting just restores the previous behavior > where overly large values are ignored when encountered (without > any direct feedback). > > Reported-by: Abdul Haleem > Signed-off-by: Jan H. Schönherr > --- > virt/kvm/eventfd.c | 2 -- > 1 file changed, 2 deletions(-) Can someone merge this or preferably just send it straight to Linus, the original patch has broken the powerpc build in mainline. cheers