Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752639AbdIRHgd (ORCPT ); Mon, 18 Sep 2017 03:36:33 -0400 Received: from nblzone-211-213.nblnetworks.fi ([83.145.211.213]:42806 "EHLO hillosipuli.retiisi.org.uk" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752062AbdIRHgb (ORCPT ); Mon, 18 Sep 2017 03:36:31 -0400 Date: Mon, 18 Sep 2017 10:36:28 +0300 From: Sakari Ailus To: Wenyou Yang Cc: Jonathan Corbet , Nicolas Ferre , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Linux Media Mailing List , Mauro Carvalho Chehab Subject: Re: [PATCH v4 2/3] media: ov7670: Add the get_fmt callback Message-ID: <20170918073628.nwjdyfdk7hvsetfb@valkosipuli.retiisi.org.uk> References: <20170918064514.6841-1-wenyou.yang@microchip.com> <20170918064514.6841-3-wenyou.yang@microchip.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170918064514.6841-3-wenyou.yang@microchip.com> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 697 Lines: 27 Hi Wenyou, On Mon, Sep 18, 2017 at 02:45:13PM +0800, Wenyou Yang wrote: > @@ -998,8 +1002,15 @@ static int ov7670_set_fmt(struct v4l2_subdev *sd, > ret = ov7670_try_fmt_internal(sd, &format->format, NULL, NULL); > if (ret) > return ret; > - cfg->try_fmt = format->format; > +#ifdef CONFIG_VIDEO_V4L2_SUBDEV_API > + struct v4l2_mbus_framefmt *mbus_fmt; This will emit a compiler warning at least. > + > + mbus_fmt = v4l2_subdev_get_try_format(sd, cfg, format->pad); > + *mbus_fmt = format->format; > return 0; > +#else > + return -ENOTTY; > +#endif > } > > ret = ov7670_try_fmt_internal(sd, &format->format, &ovfmt, &wsize); -- Sakari Ailus e-mail: sakari.ailus@iki.fi