Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752690AbdIRII7 (ORCPT ); Mon, 18 Sep 2017 04:08:59 -0400 Received: from mail.free-electrons.com ([62.4.15.54]:55897 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751700AbdIRII5 (ORCPT ); Mon, 18 Sep 2017 04:08:57 -0400 Date: Mon, 18 Sep 2017 10:08:55 +0200 From: Maxime Ripard To: Stefan =?iso-8859-1?Q?Br=FCns?= Cc: linux-sunxi@googlegroups.com, devicetree@vger.kernel.org, dmaengine@vger.kernel.org, Vinod Koul , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Chen-Yu Tsai , Rob Herring , Code Kipper , Andre Przywara Subject: Re: [PATCH v2 03/10] dmaengine: sun6i: Restructure code to allow extension for new SoCs Message-ID: <20170918080855.yxxfcfg2yttpyi5y@flea.lan> References: <20170917031956.28010-1-stefan.bruens@rwth-aachen.de> <20170917031956.28010-4-stefan.bruens@rwth-aachen.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="dix4vvap7hvwuzv2" Content-Disposition: inline In-Reply-To: <20170917031956.28010-4-stefan.bruens@rwth-aachen.de> User-Agent: NeoMutt/20170714 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1715 Lines: 49 --dix4vvap7hvwuzv2 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Sep 17, 2017 at 05:19:49AM +0200, Stefan Br=FCns wrote: > The current code mixes three distinct operations when transforming > the slave config to register settings: >=20 > 1. special handling of DMA_SLAVE_BUSWIDTH_UNDEFINED, maxburst =3D=3D 0 > 2. range checking > 3. conversion of raw to register values >=20 > As the range checks depend on the specific SoC, move these out of the > conversion to distinct operations. >=20 > Signed-off-by: Stefan Br=FCns Acked-by: Maxime Ripard Maxime --=20 Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com --dix4vvap7hvwuzv2 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIcBAEBAgAGBQJZv38XAAoJEBx+YmzsjxAgDjkP/j3HZhePfBAo/C8Rxv2MQFlm qK5o62XFog06/CrB21Xhy+37XJOfgXpR6nw/LTSmSFETAXm5VNAh+4+K2YvaSqz9 xcy+esyLbJ2fzq9cme02LRrtq2j0xXge2klr9hxYbS84M2qpeuGV9Nh4zwVL2bH+ ktZ7Sp0KfRhf6H3+QpZF/iuk3NKWHMDsUQVd5mm1Vrpsg4FcR2i498fq6rp660Sl z1dd//3mKfRQCbhjJfZzFCnmtnfMwf6KfFXZzlkVS5eZ2sCKkd4G6hB34F2gZ3aY QUdZdMnkNsRbrZNKI2hVsgUCktMcqQiRvTfQf4ILYFWM/7GTz3ns3tsEioHdYvYQ WQ6jENM50ErZoQX7Y0GSGDvAL761QOELmAoogo2/FCA9yC1rL99/Qvzn+msl8Qk2 FX26I1tjoQoaf9Py3BxIHYBlgZ34xMO7nCoZAOj+genU1GuSqeJFP09UsJY/bs7T jI98RKMcr5e+6n9dW9MVGqWLK8+ivbt1NuD3IdHOFx9ubZivRZMdTpWsNrEmLTaE RKiOXg6zdVLcfkmLfg37ZTgzqi7CTK96IQniOQiqOLcAU23NB6DUUlx+dBMTbzOl ncKXUMlAhp2/dxfJPoa7U59JSDFKDBnbu0yBsQ6iivBtiV+p0fVN2WbNk9I3ALme n2JxSiPfTITpB5Vx+KnK =n5sy -----END PGP SIGNATURE----- --dix4vvap7hvwuzv2--