Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752759AbdIRILj (ORCPT ); Mon, 18 Sep 2017 04:11:39 -0400 Received: from mail.free-electrons.com ([62.4.15.54]:56062 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752125AbdIRILg (ORCPT ); Mon, 18 Sep 2017 04:11:36 -0400 Date: Mon, 18 Sep 2017 10:11:34 +0200 From: Maxime Ripard To: Stefan =?iso-8859-1?Q?Br=FCns?= Cc: linux-sunxi@googlegroups.com, devicetree@vger.kernel.org, dmaengine@vger.kernel.org, Vinod Koul , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Chen-Yu Tsai , Rob Herring , Code Kipper , Andre Przywara Subject: Re: [PATCH v2 06/10] arm64: allwinner: a64: Add devicetree binding for DMA controller Message-ID: <20170918081134.obpoaiwd7dgzdcak@flea.lan> References: <20170917031956.28010-1-stefan.bruens@rwth-aachen.de> <20170917031956.28010-7-stefan.bruens@rwth-aachen.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="h4xpe5swv5okxfft" Content-Disposition: inline In-Reply-To: <20170917031956.28010-7-stefan.bruens@rwth-aachen.de> User-Agent: NeoMutt/20170714 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2860 Lines: 81 --h4xpe5swv5okxfft Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Sep 17, 2017 at 05:19:52AM +0200, Stefan Br=FCns wrote: > The A64 is register compatible with the H3, but has a different number > of dma channels and request ports. >=20 > Attach additional properties to the node to allow future reuse of the > compatible for controllers with different number of channels/requests. >=20 > If dma-requests is not specified, the register layout defined maximum > of 32 is used. >=20 > Signed-off-by: Stefan Br=FCns > --- > .../devicetree/bindings/dma/sun6i-dma.txt | 26 ++++++++++++++++= ++++++ > 1 file changed, 26 insertions(+) >=20 > diff --git a/Documentation/devicetree/bindings/dma/sun6i-dma.txt b/Docume= ntation/devicetree/bindings/dma/sun6i-dma.txt > index 98fbe1a5c6dd..6ebc79f95202 100644 > --- a/Documentation/devicetree/bindings/dma/sun6i-dma.txt > +++ b/Documentation/devicetree/bindings/dma/sun6i-dma.txt > @@ -27,6 +27,32 @@ Example: > #dma-cells =3D <1>; > }; > =20 > +------------------------------------------------------------------------= ------ > +For A64 DMA controller: > + > +Required properties: > +- compatible: "allwinner,sun50i-a64-dma" > +- dma-channels: Number of DMA channels supported by the controller. > + Refer to Documentation/devicetree/bindings/dma/dma.txt > +- all properties above, i.e. reg, interrupts, clocks, resets and #dma-ce= lls > + > +Optional properties: > +- dma-requests: Number of DMA request signals supported by the controlle= r. > + Refer to Documentation/devicetree/bindings/dma/dma.txt You're error'ing out if dma-requests, so it isn't optional. I guess we should just make it mandatory. Once done, Acked-by: Maxime Ripard Maxime --=20 Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com --h4xpe5swv5okxfft Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIcBAEBAgAGBQJZv3+2AAoJEBx+YmzsjxAgp/4QAKPdySi93mLQnDCjsdpOT7qf /9Z7gILHg4xLn0Cin6dP3OgPsZlmY4heoylBOLd4yPEr+Tg4CVJy1OpXppmN6dc2 DQaswqy/sHaz8xgm+GOEWP/OxFSQ33LC2NMUfhDPqjBbEVGq9Xs+wQfK6JKZhE78 RBb4lb10ow9RVuxTef2KKpH8oxCnnauYgl5xhaiKilLyjSAmA8ZwilWwGzmwsdPA 0IuV1GdvCaA6z+zQxBob4wQW3ZyO3/tavqDiRDc7ND9OXkTr1ptskc1A7ZHn/QKu 7Prmixm8XOGZ9crgLiQ1+Gh668Ey++rtxUA0sR6Rf6QZSILMzdsuFdjxKCClehvE CzlIhS5hbiH4NeJqt2Q07RLdcx1Ss4fGWG+H0ALobicURYih1M6eLbOfj5aqnC+5 PmQIrsDx9j5/el0Vg9XmFGtG5xf6Jc3322hnQDqDG4KPxSZHMANCdi7uVS9hVnyv Skt54TZ3HF/hETH67q54fHNSInCMX/19XSTA7EainuEmv2Ys4e7ExuH00dnztltU VgkOiyWJpz69ZSQB8yYSuTHMMEjZFXMLp4y4PE2Au3RZtRRyBn/8BkqUn7n5j1Jw Ef2zTwuc0MAoRVdHLyU8PMPro1WylttfdJpRd0KPKTSzIBrJNcqjILmUengA8Pzr R2iqOYMY1PIt5YpurYTE =N6gM -----END PGP SIGNATURE----- --h4xpe5swv5okxfft--