Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753481AbdIRLat (ORCPT ); Mon, 18 Sep 2017 07:30:49 -0400 Received: from mx1.redhat.com ([209.132.183.28]:59694 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752637AbdIRLas (ORCPT ); Mon, 18 Sep 2017 07:30:48 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 9E38C81F07 Authentication-Results: ext-mx02.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx02.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=jolsa@redhat.com Date: Mon, 18 Sep 2017 13:30:44 +0200 From: Jiri Olsa To: "Liang, Kan" Cc: Arnaldo Carvalho de Melo , "peterz@infradead.org" , "mingo@redhat.com" , "linux-kernel@vger.kernel.org" , "jolsa@kernel.org" , "namhyung@kernel.org" , "Hunter, Adrian" , "Odzioba, Lukasz" , "ak@linux.intel.com" Subject: Re: [PATCH RFC V2 07/10] perf tools: change machine comm_exec type to atomic Message-ID: <20170918113044.GA7518@krava> References: <1505096603-215017-1-git-send-email-kan.liang@intel.com> <1505096603-215017-8-git-send-email-kan.liang@intel.com> <20170913152410.GJ5866@kernel.org> <37D7C6CF3E00A74B8858931C1DB2F077537C026E@SHSMSX103.ccr.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <37D7C6CF3E00A74B8858931C1DB2F077537C026E@SHSMSX103.ccr.corp.intel.com> User-Agent: Mutt/1.9.0 (2017-09-02) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Mon, 18 Sep 2017 11:30:48 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 820 Lines: 21 On Fri, Sep 15, 2017 at 08:05:11PM +0000, Liang, Kan wrote: > > Em Sun, Sep 10, 2017 at 07:23:20PM -0700, kan.liang@intel.com escreveu: > > > From: Kan Liang > > > > > > In case there are two or more threads want to change it. > > > > Please describe the scenario that made you want to have this in place, to > > help in reviewing and to have it documented in this patch commit log. > > > > Thinking more about it. For synthesizing event, we don't need to change the > comm_exec. PERF_RECORD_MISC_COMM_EXEC is not set in this stage. > But we should consider it if we want to multithread the event processing stage. > > Since it's not an issue for now, I will drop this patch and add some comments > in the code for V3. any chance you could push v3 into a git branch somewhere? thanks, jirka