Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S266068AbTGISrS (ORCPT ); Wed, 9 Jul 2003 14:47:18 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S268471AbTGISrS (ORCPT ); Wed, 9 Jul 2003 14:47:18 -0400 Received: from dnsc6804027.pnl.gov ([198.128.64.39]:43654 "EHLO schatzie.adilger.int") by vger.kernel.org with ESMTP id S266068AbTGISrR (ORCPT ); Wed, 9 Jul 2003 14:47:17 -0400 Date: Wed, 9 Jul 2003 11:51:48 -0700 From: Andreas Dilger To: Trond Myklebust Cc: Marcelo Tosatti , Christoph Hellwig , marcelo@connectiva.com.br, lkml Subject: Re: ->direct_IO API change in current 2.4 BK Message-ID: <20030709115148.L4482@schatzie.adilger.int> Mail-Followup-To: Trond Myklebust , Marcelo Tosatti , Christoph Hellwig , marcelo@connectiva.com.br, lkml References: <20030709133109.A23587@infradead.org> <20030709100336.H4482@schatzie.adilger.int> <16140.24322.464839.812346@charged.uio.no> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5.1i In-Reply-To: <16140.24322.464839.812346@charged.uio.no>; from trond.myklebust@fys.uio.no on Wed, Jul 09, 2003 at 08:29:22PM +0200 X-GPG-Key: 1024D/0D35BED6 X-GPG-Fingerprint: 7A37 5D79 BF1B CECA D44F 8A29 A488 39F5 0D35 BED6 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 845 Lines: 21 On Jul 09, 2003 20:29 +0200, Trond Myklebust wrote: > How about instead following Alan's suggestion to replace > KERNEL_HAS_O_DIRECT with a KERNEL_HAS_O_DIRECT2 that can be used to > switch between the old and new O_DIRECT format in the XFS patches? Actually, I like that a lot more, as it allows out-of-tree code to know which interface to use, and we don't have to key on kernel version (which is bogus if compiling against a vendor kernel that back-ports this fix). Cheers, Andreas -- Andreas Dilger http://sourceforge.net/projects/ext2resize/ http://www-mddsp.enel.ucalgary.ca/People/adilger/ - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/