Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754535AbdIRM3J (ORCPT ); Mon, 18 Sep 2017 08:29:09 -0400 Received: from mail-io0-f176.google.com ([209.85.223.176]:56004 "EHLO mail-io0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754199AbdIRM3H (ORCPT ); Mon, 18 Sep 2017 08:29:07 -0400 X-Google-Smtp-Source: AOwi7QAXCZf2NmZd8veJ9K7vWytXtCnHHn+lh+zFoQVHj2VuS0mV5BkO4W3wTD5QSAPF72HNRSR2lAkrGjXlsW1Xn8g= MIME-Version: 1.0 In-Reply-To: <20170914190247.rrbdzdexjjywxipf@linux.intel.com> References: <20170911100022.7251-1-tweek@google.com> <20170911100022.7251-3-tweek@google.com> <20170914184126.eevnstwq3i6fiq4j@linux.intel.com> <20170914190247.rrbdzdexjjywxipf@linux.intel.com> From: Thiebaud Weksteen Date: Mon, 18 Sep 2017 14:28:45 +0200 Message-ID: Subject: Re: [PATCH v2 2/3] efi: call get_event_log before ExitBootServices To: Jarkko Sakkinen Cc: Matthew Garrett , linux-efi@vger.kernel.org, Ard Biesheuvel , Matt Fleming , linux-kernel@vger.kernel.org, tpmdd-devel@lists.sourceforge.net, peterhuewe@gmx.de, Jason Gunthorpe , tpmdd@selhorst.net Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by nfs id v8ICTHIT024597 Content-Length: 1874 Lines: 46 On Thu, Sep 14, 2017 at 9:02 PM, Jarkko Sakkinen wrote: > On Thu, Sep 14, 2017 at 11:48:54AM -0700, Matthew Garrett wrote: >> On Thu, Sep 14, 2017 at 11:43 AM, Jarkko Sakkinen >> wrote: >> > On Mon, Sep 11, 2017 at 12:00:21PM +0200, Thiebaud Weksteen wrote: >> >> With TPM 2.0 specification, the event logs may only be accessible by >> >> calling an EFI Boot Service. Modify the EFI stub to copy the log area to >> >> a new Linux-specific EFI configuration table so it remains accessible >> >> once booted. >> >> >> >> When calling this service, it is possible to specify the expected format >> >> of the logs: TPM 1.2 (SHA1) or TPM 2.0 ("Crypto Agile"). For now, only the >> >> first format is retrieved. >> >> >> >> Signed-off-by: Thiebaud Weksteen >> > >> > With a quick skim the code change looks good but I remember from >> > Matthew's talk that there was this issue that ExitBootServices() would >> > cause a yet another event? >> > >> > I guess you could manually synthetize that event by reading the PCR >> > values right after ExitBootServices()? >> >> I think that would involve breaking SHA1… the information should be > > You are absolutely right, was not thinking clearly :-) > >> available in the TCG_TREE_FINAL_EVENTS configuration table, so it >> /should/ just be a matter of merging the events from that into the >> event log. > > Right, it is available through runtime services. Why this isn't part > of the patch set? This is not included yet as this table (EFI_TCG2_FINAL_EVENTS_TABLE_GUID) relies on the TPM2 format for the log entries (TCG_PCR_EVENT2, "Crypto Agile"). I first plan to add the parsing of this log version (ie, efi_retrieve_tpm2_eventlog_2) before adding the merging of both tables. But these will be separate patch sets. > > /Jrakko > > /Jarkko