Date: Mon, 18 Sep 2017 15:46:25 +0300
From: Yury Norov <ynorov@caviumnetworks.com>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: "linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
        Jonathan Corbet <corbet@lwn.net>, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Documentation: kernel-api: add bitmap operations from
 linux/bitmap.h
Message-ID: <20170918124625.45tugxspqpb4y6jj@yury-thinkpad>
References: <8dc0abb6-a138-29f8-f37c-27a1e545f098@infradead.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <8dc0abb6-a138-29f8-f37c-27a1e545f098@infradead.org>
User-Agent: NeoMutt/20170113 (1.7.2)
SpamDiagnosticOutput: 1:99
SpamDiagnosticMetadata: NSPM
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Sep 2017 12:46:41.8097 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR0701MB3827
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 2034
Lines: 60

On Sun, Sep 17, 2017 at 07:07:10PM -0700, Randy Dunlap wrote:
> From: Randy Dunlap <rdunlap@infradead.org>
> 
> Add <linux/bitmap.h> to kernel-api Bitmap Operations section.
> Fix kernel-doc nitpicks in <linux/bitmap.h>.
> 
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Yury Norov <ynorov@caviumnetworks.com>

Acked-by: Yury Norov <ynorov@caviumnetworks.com>

> ---
>  Documentation/core-api/kernel-api.rst |    3 +++
>  include/linux/bitmap.h                |    9 +++++----
>  2 files changed, 8 insertions(+), 4 deletions(-)
> 
> --- lnx-414-rc1.orig/Documentation/core-api/kernel-api.rst
> +++ lnx-414-rc1/Documentation/core-api/kernel-api.rst
> @@ -59,6 +59,9 @@ Bitmap Operations
>  .. kernel-doc:: lib/bitmap.c
>     :internal:
>  
> +.. kernel-doc:: include/linux/bitmap.h
> +   :internal:
> +
>  Command-line Parsing
>  --------------------
>  
> --- lnx-414-rc1.orig/include/linux/bitmap.h
> +++ lnx-414-rc1/include/linux/bitmap.h
> @@ -360,8 +360,9 @@ static inline int bitmap_parse(const cha
>  	return __bitmap_parse(buf, buflen, 0, maskp, nmaskbits);
>  }
>  
> -/*
> +/**
>   * BITMAP_FROM_U64() - Represent u64 value in the format suitable for bitmap.
> + * @n: u64 value
>   *
>   * Linux bitmaps are internally arrays of unsigned longs, i.e. 32-bit
>   * integers in 32-bit environment, and 64-bit integers in 64-bit one.
> @@ -392,14 +393,14 @@ static inline int bitmap_parse(const cha
>  				((unsigned long) ((u64)(n) >> 32))
>  #endif
>  
> -/*
> +/**
>   * bitmap_from_u64 - Check and swap words within u64.
>   *  @mask: source bitmap
>   *  @dst:  destination bitmap
>   *
> - * In 32-bit Big Endian kernel, when using (u32 *)(&val)[*]
> + * In 32-bit Big Endian kernel, when using ``(u32 *)(&val)[*]``
>   * to read u64 mask, we will get the wrong word.
> - * That is "(u32 *)(&val)[0]" gets the upper 32 bits,
> + * That is ``(u32 *)(&val)[0]`` gets the upper 32 bits,
>   * but we expect the lower 32-bits of u64.
>   */
>  static inline void bitmap_from_u64(unsigned long *dst, u64 mask)
>