Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S932492AbdIRM5L (ORCPT <rfc822;w@1wt.eu>);
        Mon, 18 Sep 2017 08:57:11 -0400
Received: from mail-qk0-f169.google.com ([209.85.220.169]:52132 "EHLO
        mail-qk0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752392AbdIRM5J (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 18 Sep 2017 08:57:09 -0400
X-Google-Smtp-Source: AOwi7QDixMmgfbEYJXuCy0EQvdlxYMD9tI1al9ncGsO3WkI7We8jVFdnQdM1bbdtsnp/9aaFTVW8joybtv1yLJrNGb0=
MIME-Version: 1.0
In-Reply-To: <59BEEC39.2030609@googlemail.com>
References: <59BEEC39.2030609@googlemail.com>
From: Devin Heitmueller <dheitmueller@kernellabs.com>
Date: Mon, 18 Sep 2017 08:57:08 -0400
Message-ID: <CAGoCfizQS3fg2Sqjtg2ypiCqa5cMQ=irMZ1nwEVJ8+TeBuAZCA@mail.gmail.com>
Subject: Re: [PATCH] Support HVR-1200 analog video as a clone of HVR-1500.
 Tested, composite and s-video inputs.
To: Nigel Kettlewell <nigel.kettlewell@googlemail.com>
Cc: Linux Media Mailing List <linux-media@vger.kernel.org>,
        Linux Kernel <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1129
Lines: 30

On Sun, Sep 17, 2017 at 5:42 PM, Nigel Kettlewell
<nigel.kettlewell@googlemail.com> wrote:
> I propose the following patch to support Hauppauge HVR-1200 analog video,
> nothing more than a clone of HVR-1500. Patch based on Linux 4.9 commit
> 69973b830859bc6529a7a0468ba0d80ee5117826
>
> I have tested composite and S-Video inputs.
>
> With the change, HVR-1200 devices have a /dev/video<n> entry which is
> accessible in the normal way.
>
> Let me know if you need anything more.

I'm not confident the tuner config for this board is correct.  The
HVR-1200 is much closer to the HVR-1250 as opposed to the HVR-1500,
and IIRC it didn't have an xc3028.

I don't dispute that with the patch in question the composite/s-video
are probably working ok, but I wouldn't recommend accepting this patch
as-is until the tuner is verified for DVB-T and analog (ideally both).

Can you provide the output of dmesg on device load?  If it's filled
with a bunch of errors showing xc3028 firmware load failures, that
would be a smoking gun that it doesn't have the xc3028.

Devin

-- 
Devin J. Heitmueller - Kernel Labs
http://www.kernellabs.com