Date: Mon, 18 Sep 2017 15:59:55 +0200
From: Greg KH <gregkh@linuxfoundation.org>
To: kys@microsoft.com
Cc: linux-kernel@vger.kernel.org, devel@linuxdriverproject.org,
        olaf@aepfle.de, apw@canonical.com, vkuznets@redhat.com,
        jasowang@redhat.com, leann.ogasawara@canonical.com,
        marcelo.cerri@canonical.com, sthemmin@microsoft.com
Subject: Re: [PATCH V2 3/4] vmbus: add per-channel sysfs info
Message-ID: <20170918135955.GD21077@kroah.com>
References: <20170918034955.10913-1-kys@exchange.microsoft.com>
 <20170918035419.11062-1-kys@exchange.microsoft.com>
 <20170918035419.11062-3-kys@exchange.microsoft.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20170918035419.11062-3-kys@exchange.microsoft.com>
User-Agent: Mutt/1.9.0 (2017-09-02)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1099
Lines: 27

On Sun, Sep 17, 2017 at 08:54:18PM -0700, kys@exchange.microsoft.com wrote:
> From: Stephen Hemminger <stephen@networkplumber.org>
> 
> This extends existing vmbus related sysfs structure to provide per-channel
> state information. This is useful when diagnosing issues with multiple
> queues in networking and storage.
> 
> The existing sysfs only displayed information about the primary
> channel. The one place it reported multiple channels was the
> channel_vp_mapping file which violated the sysfs convention
> of one value per file.
> 
> Signed-off-by: Stephen Hemminger <sthemmin@microsoft.com>
> Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
> ---
>  Documentation/ABI/stable/sysfs-bus-vmbus |  56 ++++++++++
>  drivers/hv/channel_mgmt.c                |  10 +-
>  drivers/hv/hyperv_vmbus.h                |   2 +
>  drivers/hv/vmbus_drv.c                   | 185 +++++++++++++++++++++++++++++--
>  include/linux/hyperv.h                   |   6 +
>  5 files changed, 246 insertions(+), 13 deletions(-)

Feels like a new feature to me, and not needed in 4.14-final.

thanks,

greg k-h