Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752875AbdIROAO (ORCPT ); Mon, 18 Sep 2017 10:00:14 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:57608 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752133AbdIROAN (ORCPT ); Mon, 18 Sep 2017 10:00:13 -0400 Date: Mon, 18 Sep 2017 16:00:24 +0200 From: Greg KH To: kys@microsoft.com Cc: linux-kernel@vger.kernel.org, devel@linuxdriverproject.org, olaf@aepfle.de, apw@canonical.com, vkuznets@redhat.com, jasowang@redhat.com, leann.ogasawara@canonical.com, marcelo.cerri@canonical.com, sthemmin@microsoft.com, Haiyang Zhang Subject: Re: [PATCH V2 1/4] vmbus: don't acquire the mutex in vmbus_hvsock_device_unregister() Message-ID: <20170918140024.GE21077@kroah.com> References: <20170918034955.10913-1-kys@exchange.microsoft.com> <20170918035419.11062-1-kys@exchange.microsoft.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170918035419.11062-1-kys@exchange.microsoft.com> User-Agent: Mutt/1.9.0 (2017-09-02) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 914 Lines: 23 On Sun, Sep 17, 2017 at 08:54:16PM -0700, kys@exchange.microsoft.com wrote: > From: Dexuan Cui > > Due to commit 54a66265d675 ("Drivers: hv: vmbus: Fix rescind handling"), > we need this patch to resolve the below deadlock: > > after we get the mutex in vmbus_hvsock_device_unregister() and call > vmbus_device_unregister() -> device_unregister() -> ... -> device_release() > -> vmbus_device_release(), we'll get a deadlock, because > vmbus_device_release() tries to get the same mutex. > > Signed-off-by: Dexuan Cui > Cc: K. Y. Srinivasan > Cc: Haiyang Zhang > Cc: Stephen Hemminger > Signed-off-by: K. Y. Srinivasan As every one of these patches had questions from me, please break them up into different series, one for 4.14-final, and one for 4.15-rc1. thanks, greg k-h