Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755022AbdIROnz (ORCPT ); Mon, 18 Sep 2017 10:43:55 -0400 Received: from mail-by2nam01on0138.outbound.protection.outlook.com ([104.47.34.138]:17225 "EHLO NAM01-BY2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753495AbdIROnx (ORCPT ); Mon, 18 Sep 2017 10:43:53 -0400 From: KY Srinivasan To: Greg KH CC: "linux-kernel@vger.kernel.org" , "devel@linuxdriverproject.org" , "olaf@aepfle.de" , "apw@canonical.com" , "vkuznets@redhat.com" , "jasowang@redhat.com" , "leann.ogasawara@canonical.com" , "marcelo.cerri@canonical.com" , Stephen Hemminger , Haiyang Zhang Subject: RE: [PATCH V2 1/4] vmbus: don't acquire the mutex in vmbus_hvsock_device_unregister() Thread-Topic: [PATCH V2 1/4] vmbus: don't acquire the mutex in vmbus_hvsock_device_unregister() Thread-Index: AQHTMDH1gB+19iZrnkazDiSCGxqTtKK6rI4AgAAMDwA= Date: Mon, 18 Sep 2017 14:43:51 +0000 Message-ID: References: <20170918034955.10913-1-kys@exchange.microsoft.com> <20170918035419.11062-1-kys@exchange.microsoft.com> <20170918140024.GE21077@kroah.com> In-Reply-To: <20170918140024.GE21077@kroah.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Enabled=True; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SiteId=72f988bf-86f1-41af-91ab-2d7cd011db47; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Ref=https://api.informationprotection.azure.com/api/72f988bf-86f1-41af-91ab-2d7cd011db47; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Owner=kys@microsoft.com; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SetDate=2017-09-18T07:43:49.2485286-07:00; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Name=General; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Application=Microsoft Azure Information Protection; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Extended_MSFT_Method=Automatic; Sensitivity=General x-originating-ip: [73.254.106.230] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;DM5PR21MB0140;6:B+5cE1VbEEYzRVsCojNPgc7YWnnTuoEUJ0z2AOPU/ntFU+QO6LZM34F7YBwqV/poJcpcroCkhm8kIf/41WRSn59SppVGBhQZPzpaPGREDrOA6kULIdsiwbExZ6xeNUnA+2JEFXHXOtxRl+Oba0Q1eUechkHXNNtDm3wBd+/OiarnaLFicyYs/F3P9edISeE56qscLtLKA22q7unfL8olMCfQ+QjsxwS2VSwC0DZPRosDrjWqF4qTnsJMcX9dwJk5Ib7TCaocPFq38Yg/rA6jAO7ksFdCa0kVkot7q3rfqj6Eo7PSMEGp1NGXzo3hlyUzkAX4L/bd6KUVvWLZUBBIsQ==;5:19/dS/uDFElScU8bVVh0L0upt06J836uyCJ/OgG5+jPwb1ylwMo49wY9cK7iutnY4uNZqnb4F5GsuHnMryOM7phkGpE1OPQeS2Uj/Fs7cTu/fZaaeSjXaAMg0ps2sZwK1Xmeh3bDLCw/jvhSITBDKA==;24:Zj8c1Xu2fa9rHaHq5bo04KhiAZvhNMCSZwfKuCb14Zp22iP/2mc3fcZ6O3shJ30fTQuGt9xV5RnFOVe2r9PVZe5EkxDJ5EJhWNcVFjUG7PE=;7:SBtBUHrAiuFFFy4yXIusPE2GjD5r9EcCGVWhZp5kn5Fh/l6U/ze79Ua40EZ7mxbQ2VyzDdE4us0NRsbZrVVEL7E3qcsfRZHDvdLYSWBENSpdKRpN2mEdSX2k5SjtUKkTzuRR3rqqGZp1WVJuAdhjnmGzj6kpldIIH1QFAmJm+s1CwfNPfkgT4JVE0b6+A2EFakQnWErNo6DJfKsdInXCd3KNlepaIFI4px81CsuuUK8= x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-correlation-id: 213aa8fa-d35d-4cc9-8ce8-08d4fea3adbe x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(48565401081)(300000503095)(300135400095)(2017052603199)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095);SRVR:DM5PR21MB0140; x-ms-traffictypediagnostic: DM5PR21MB0140: authentication-results: spf=none (sender IP is ) smtp.mailfrom=kys@microsoft.com; x-exchange-antispam-report-test: UriScan:(89211679590171)(9452136761055)(140211028294663)(198206253151910); x-microsoft-antispam-prvs: x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(61425038)(6040450)(2401047)(5005006)(8121501046)(93006095)(93001095)(100000703101)(100105400095)(10201501046)(3002001)(6055026)(61426038)(61427038)(6041248)(20161123560025)(20161123555025)(20161123564025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123562025)(20161123558100)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:DM5PR21MB0140;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:DM5PR21MB0140; x-forefront-prvs: 04347F8039 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(6009001)(376002)(346002)(39860400002)(47760400005)(189002)(13464003)(24454002)(377454003)(199003)(86612001)(10290500003)(8990500004)(25786009)(3280700002)(6916009)(2950100002)(105586002)(5660300001)(106356001)(2906002)(478600001)(86362001)(22452003)(316002)(74316002)(3660700001)(33656002)(7736002)(68736007)(305945005)(6506006)(9686003)(81156014)(97736004)(81166006)(77096006)(66066001)(53936002)(2900100001)(99286003)(54906002)(6246003)(229853002)(107886003)(110136004)(6436002)(7696004)(8936002)(189998001)(101416001)(8676002)(4326008)(10090500001)(6116002)(14454004)(3846002)(102836003)(53546010)(55016002)(76176999)(54356999)(50986999);DIR:OUT;SFP:1102;SCL:1;SRVR:DM5PR21MB0140;H:DM5PR21MB0476.namprd21.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Sep 2017 14:43:51.2903 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR21MB0140 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by nfs id v8IEi0Os032105 Content-Length: 1548 Lines: 45 > -----Original Message----- > From: Greg KH [mailto:gregkh@linuxfoundation.org] > Sent: Monday, September 18, 2017 7:00 AM > To: KY Srinivasan > Cc: linux-kernel@vger.kernel.org; devel@linuxdriverproject.org; > olaf@aepfle.de; apw@canonical.com; vkuznets@redhat.com; > jasowang@redhat.com; leann.ogasawara@canonical.com; > marcelo.cerri@canonical.com; Stephen Hemminger > ; Haiyang Zhang > Subject: Re: [PATCH V2 1/4] vmbus: don't acquire the mutex in > vmbus_hvsock_device_unregister() > > On Sun, Sep 17, 2017 at 08:54:16PM -0700, kys@exchange.microsoft.com > wrote: > > From: Dexuan Cui > > > > Due to commit 54a66265d675 ("Drivers: hv: vmbus: Fix rescind handling"), > > we need this patch to resolve the below deadlock: > > > > after we get the mutex in vmbus_hvsock_device_unregister() and call > > vmbus_device_unregister() -> device_unregister() -> ... -> > device_release() > > -> vmbus_device_release(), we'll get a deadlock, because > > vmbus_device_release() tries to get the same mutex. > > > > Signed-off-by: Dexuan Cui > > Cc: K. Y. Srinivasan > > Cc: Haiyang Zhang > > Cc: Stephen Hemminger > > Signed-off-by: K. Y. Srinivasan > > As every one of these patches had questions from me, please break them > up into different series, one for 4.14-final, and one for 4.15-rc1. Will do. Thanks, K. Y > > thanks, > > greg k-h