Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753583AbdIRP3C (ORCPT ); Mon, 18 Sep 2017 11:29:02 -0400 Received: from mail-io0-f173.google.com ([209.85.223.173]:55662 "EHLO mail-io0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753168AbdIRP27 (ORCPT ); Mon, 18 Sep 2017 11:28:59 -0400 X-Google-Smtp-Source: AOwi7QBQgaHx3K8EhmZp88yFaxlaYXoqxA6xSlGIxNoGfPHyT2T/CwnQxqkJiSCoaffStw7XmYG2Uw== Subject: Re: [linux-next][XFS][trinity] WARNING: CPU: 32 PID: 31369 at fs/iomap.c:993 To: Christoph Hellwig , Abdul Haleem Cc: linuxppc-dev , linux-xfs , linux-next , linux-kernel , chandan References: <1505746565.6990.18.camel@abdul.in.ibm.com> <20170918152706.GA11482@lst.de> From: Jens Axboe Message-ID: <8abed401-1634-760f-6543-4652fa495315@kernel.dk> Date: Mon, 18 Sep 2017 09:28:55 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <20170918152706.GA11482@lst.de> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 664 Lines: 26 On 09/18/2017 09:27 AM, Christoph Hellwig wrote: > On Mon, Sep 18, 2017 at 08:26:05PM +0530, Abdul Haleem wrote: >> Hi, >> >> A warning is triggered from: >> >> file fs/iomap.c in function iomap_dio_rw >> >> if (ret) >> goto out_free_dio; >> >> ret = invalidate_inode_pages2_range(mapping, >> start >> PAGE_SHIFT, end >> PAGE_SHIFT); >>>> WARN_ON_ONCE(ret); >> ret = 0; >> >> inode_dio_begin(inode); > > This is expected and an indication of a problematic workload - which > may be triggered by a fuzzer. If it's expected, why don't we kill the WARN_ON_ONCE()? I get it all the time running xfstests as well. -- Jens Axboe