Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756065AbdIRQOu (ORCPT ); Mon, 18 Sep 2017 12:14:50 -0400 Received: from smtprelay4.synopsys.com ([198.182.47.9]:51299 "EHLO smtprelay.synopsys.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753310AbdIRQOt (ORCPT ); Mon, 18 Sep 2017 12:14:49 -0400 Subject: Re: [PATCH v2] ARC: reset: introduce AXS10x reset driver To: Philipp Zabel , Eugeniy Paltsev CC: , , , Rob Herring , Mark Rutland Newsgroups: gmane.linux.kernel,gmane.linux.kernel.arc,gmane.linux.drivers.devicetree References: <20170914142842.12225-1-Eugeniy.Paltsev@synopsys.com> <1505736441.9807.8.camel@pengutronix.de> From: Vineet Gupta Message-ID: Date: Mon, 18 Sep 2017 09:14:38 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <1505736441.9807.8.camel@pengutronix.de> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.10.161.39] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1472 Lines: 38 Hi Philipp, On 09/18/2017 05:07 AM, Philipp Zabel wrote: > On Thu, 2017-09-14 at 17:28 +0300, Eugeniy Paltsev wrote: >> ARC AXS10x boards support custom IP-block which allows to control >> reset signals of selected peripherals. For example DW GMAC, etc... >> This block is controlled via memory-mapped register (AKA CREG) which >> represents up-to 32 reset lines. This regiter is self-clearing so we >> don't need to deassert line after reset. >> >> As of today only the following lines are used: >> - DW GMAC - line 5 >> >>> Signed-off-by: Eugeniy Paltsev >> --- >> Changes v1 -> v2: >> * The creg reset register is self-clearing so we don't need to clear it >> manually. Fixed it. >> * Use reset callback instead of assert/deassert pair. >> * Rename reset node in documentation to "reset-controller" for consistency >> with the other bindings. >> * Use devm_reset_controller_register instead of reset_controller_register >> >> NOTE: >> This driver couldn't be replaced by reset-simple driver as we mustn't >> read from reset register or clear it. > > Thanks, I've applied this patch to the reset/next branch. Will it be OK for you to apply the corresponding DT update for platform - that way I don't have to keep track of when ur branch hits mainline etc. The chances of any ensuing conflicts are pretty rare - and easy to resolve if at all. If so, Eugeniy can send the patch ur way ! Thx, -Vineet