Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932707AbdIRQg2 (ORCPT ); Mon, 18 Sep 2017 12:36:28 -0400 Received: from esa4.hgst.iphmx.com ([216.71.154.42]:15622 "EHLO esa4.hgst.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755889AbdIRQg0 (ORCPT ); Mon, 18 Sep 2017 12:36:26 -0400 X-IronPort-AV: E=Sophos;i="5.42,413,1500912000"; d="scan'208";a="51979974" From: Bart Van Assche To: "mingo@kernel.org" , "longman@redhat.com" , "rostedt@goodmis.org" , "axboe@kernel.dk" CC: "linux-kernel@vger.kernel.org" , "linux-block@vger.kernel.org" Subject: Re: [PATCH v5] blktrace: Fix potentail deadlock between delete & sysfs ops Thread-Topic: [PATCH v5] blktrace: Fix potentail deadlock between delete & sysfs ops Thread-Index: AQHTL13sfEuB69urq0C2j1m5hBFypaK62coA Date: Mon, 18 Sep 2017 16:36:23 +0000 Message-ID: <1505752582.2685.11.camel@wdc.com> References: <1505615828-6623-1-git-send-email-longman@redhat.com> In-Reply-To: <1505615828-6623-1-git-send-email-longman@redhat.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Bart.VanAssche@wdc.com; x-originating-ip: [63.163.107.201] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;CY1PR0401MB1114;20:joSew1OPl8JPqoAyADDNDd5rt0em/ACAxPwp8h9rI1uwyNPBVNcXi9ORkswGe2x2C9FVgOVRN19kCJiphG1cu5QDqeIdG1Xp/U/MfmgE2L6+LKhs7JvfDXu0+3acQZG0jeZ0MtTpQdKtRx685XtJuuJovOuIebLae4Te1G8p0Sk= x-ms-exchange-antispam-srfa-diagnostics: SSOS; x-ms-office365-filtering-correlation-id: a2986fad-cdfd-4b28-aa26-08d4feb366a5 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(48565401081)(300000503095)(300135400095)(2017052603199)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095);SRVR:CY1PR0401MB1114; x-ms-traffictypediagnostic: CY1PR0401MB1114: wdcipoutbound: EOP-TRUE x-exchange-antispam-report-test: UriScan:; x-microsoft-antispam-prvs: x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(5005006)(8121501046)(100000703101)(100105400095)(3002001)(93006095)(93001095)(10201501046)(6055026)(6041248)(20161123558100)(20161123564025)(20161123560025)(20161123562025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123555025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:CY1PR0401MB1114;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:CY1PR0401MB1114; x-forefront-prvs: 04347F8039 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(6009001)(346002)(376002)(39860400002)(199003)(24454002)(377424004)(189002)(14454004)(316002)(86362001)(2900100001)(97736004)(6436002)(81156014)(81166006)(101416001)(54906002)(99286003)(106356001)(105586002)(3846002)(102836003)(189998001)(6116002)(229853002)(68736007)(36756003)(8676002)(6486002)(77096006)(6506006)(6512007)(72206003)(50986999)(76176999)(54356999)(33646002)(2201001)(305945005)(66066001)(2501003)(3280700002)(3660700001)(8936002)(478600001)(4326008)(103116003)(5660300001)(2906002)(7736002)(2950100002)(25786009)(53936002)(6246003);DIR:OUT;SFP:1102;SCL:1;SRVR:CY1PR0401MB1114;H:CY1PR0401MB1536.namprd04.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="utf-8" Content-ID: <898810CB6C25584995121A3672509859@namprd04.prod.outlook.com> MIME-Version: 1.0 X-OriginatorOrg: wdc.com X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Sep 2017 16:36:23.8472 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR0401MB1114 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by nfs id v8IGaXtF007371 Content-Length: 593 Lines: 20 On Sat, 2017-09-16 at 19:37 -0700, Waiman Long wrote: > diff --git a/include/linux/fs.h b/include/linux/fs.h > index 339e737..330b572 100644 > --- a/include/linux/fs.h > +++ b/include/linux/fs.h > @@ -448,7 +448,7 @@ struct block_device { > > /* The counter of freeze processes */ > int bd_fsfreeze_count; > - /* Mutex for freeze */ > + /* Mutex for freeze and blktrace */ > struct mutex bd_fsfreeze_mutex; > } __randomize_layout; This patch changes the meaning of bd_fsfreeze_mutex significantly. Please rename that mutex such that its name matches its new role. Thanks, Bart.