Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756149AbdIRR26 (ORCPT ); Mon, 18 Sep 2017 13:28:58 -0400 Received: from anholt.net ([50.246.234.109]:42304 "EHLO anholt.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756087AbdIRR25 (ORCPT ); Mon, 18 Sep 2017 13:28:57 -0400 From: Eric Anholt To: Arvind Yadav , airlied@linux.ie Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: Re: [PATCH] drm: pl111: constify amba_id In-Reply-To: <86980e42a00d789655e390cd4ae9b1caeadf5ead.1503504813.git.arvind.yadav.cs@gmail.com> References: <86980e42a00d789655e390cd4ae9b1caeadf5ead.1503504813.git.arvind.yadav.cs@gmail.com> User-Agent: Notmuch/0.22.2+1~gb0bcfaa (http://notmuchmail.org) Emacs/25.2.2 (x86_64-pc-linux-gnu) Date: Mon, 18 Sep 2017 10:28:25 -0700 Message-ID: <87shfjsypy.fsf@anholt.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1954 Lines: 55 --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Arvind Yadav writes: > amba_id are not supposed to change at runtime. All functions > working with const amba_id. So mark the non-const structs as const. > > Signed-off-by: Arvind Yadav > --- > drivers/gpu/drm/pl111/pl111_drv.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/pl111/pl111_drv.c b/drivers/gpu/drm/pl111/pl= 111_drv.c > index ac8771b..522875c 100644 > --- a/drivers/gpu/drm/pl111/pl111_drv.c > +++ b/drivers/gpu/drm/pl111/pl111_drv.c > @@ -243,7 +243,7 @@ static int pl111_amba_remove(struct amba_device *amba= _dev) > return 0; > } >=20=20 > -static struct amba_id pl111_id_table[] =3D { > +static const struct amba_id pl111_id_table[] =3D { > { > .id =3D 0x00041111, > .mask =3D 0x000fffff, > --=20 > 2.7.4 Sorry about dropping your patch here -- Linus was working on a bigger series for pl110 support that also happened to fix this. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEE/JuuFDWp9/ZkuCBXtdYpNtH8nugFAlnAAjkACgkQtdYpNtH8 nuj62Q//Vo77+4QwEP675lt707K950ZpETFV8GAEdQj58Aj2NJUIRdnj3fom2Y3Y OqWsEram2fQnT2TdlER9UajuriXb53IGVYTs3AhVjhDTbGWFLZc8xZKtu8hPvx0s yiFVGRnnlgGYTsyi+virYfgYjNPY1xY7wRLOZVvXPVzkL5onF7yRgabDeCDcGZTp 7GIvsQlZW0CzwSQZ+Uo4fz+DSsS5glBVCHg5dT8RJbUQa+dYpZxkpG8Et+pehmpd GJv4j7AH3dNBY2nyTSFqq5MRnoDCCehhWh1H5ucaT9xNLPuEzk1IKb2bimpr933G xulCqQ2FjfPbEV2E6ffD/H3+1wd1uh7BQFUnsGmwg23uEQCs3NZBjjADG++kZX7R BAsHh+tx0kL1QyOBQ4Q2M7b6zBlzHuab9DUsJnhbw/l36Q+x3Q8YmJLk817bi6rJ 6J+goWLVDu8fO/beI/RqDpzXUS/LPKd8I4M+mzvwipvGitEerl9FBZOws2HrPmu0 WJ/jnlG8QvrPQ5m6b9EaQQLSfFnLR05fePvermMFN1oGZ+05TH7lP6UkK0z1NArY k0UaeUkojW3V68jntTddxvsug+T/VNVmUVHNOXpI/PJzevrBssL9Jq9MoBqPOriL tG2Sg3TKXD4HQ0p3DQIwwISVSTuVYjrcQqPPpH0Zh3eubFa1mAU= =ZZS8 -----END PGP SIGNATURE----- --=-=-=--