DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 8E80F81DF5
Subject: Re: [PATCH 0/3] fix reuseaddr regression
To: josef@toxicpanda.com, davem@davemloft.net, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org, labbott@redhat.com, kernel-team@fb.com
References: <1505752137-15522-1-git-send-email-jbacik@fb.com>
From: Cole Robinson <crobinso@redhat.com>
Message-ID: <5df48cbb-2726-3e99-84e7-eb6c6fc0dbb2@redhat.com>
Date: Mon, 18 Sep 2017 13:44:32 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.3.0
MIME-Version: 1.0
In-Reply-To: <1505752137-15522-1-git-send-email-jbacik@fb.com>
Content-Type: text/plain; charset=us-ascii
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 832
Lines: 18

On 09/18/2017 12:28 PM, josef@toxicpanda.com wrote:
> I introduced a regression when reworking the fastreuse port stuff that allows
> bind conflicts to occur once a reuseaddr socket successfully opens on an
> existing tb.  The root cause is I reversed an if statement which caused us to
> set the tb as if there were no owners on the socket if there were, which
> obviously is not correct.
> 
> Dave I have follow up patches that will add a selftest for this case and I ran
> the other reuseport related tests as well.  These need to go in pretty quickly
> as it breaks kvm, I've marked them for stable.  Sorry for the regression,
> 

To clarify, it doesn't really break KVM specifically, but it breaks a
port collision detection idiom that libvirt depends on to successfully
launch qemu/xen/... VMs in certain cases.

Thanks,
Cole