Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756572AbdIRSRw (ORCPT ); Mon, 18 Sep 2017 14:17:52 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:36383 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752757AbdIRSRu (ORCPT ); Mon, 18 Sep 2017 14:17:50 -0400 Subject: Re: [PATCH] gpio: omap: omap_gpio_show_rev is not __init To: Arnd Bergmann , Grygorii Strashko , Santosh Shilimkar , Kevin Hilman , Linus Walleij Cc: linux-omap@vger.kernel.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org References: <20170916204234.725130-1-arnd@arndb.de> From: Santosh Shilimkar Organization: Oracle Corporation Message-ID: Date: Mon, 18 Sep 2017 11:18:23 -0700 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <20170916204234.725130-1-arnd@arndb.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Source-IP: aserv0021.oracle.com [141.146.126.233] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 724 Lines: 17 On 9/16/2017 1:42 PM, Arnd Bergmann wrote: > The probe function calls omap_gpio_show_rev(), which on most > compilers is inlined, but on the old gcc-4.6 is not, causing > a valid warning about the incorrect __init annotation: > > WARNING: vmlinux.o(.text+0x40f614): Section mismatch in reference from the function omap_gpio_probe() to the function .init.text:omap_gpio_show_rev() > The function omap_gpio_probe() references > the function __init omap_gpio_show_rev(). > This is often because omap_gpio_probe lacks a __init > annotation or the annotation of omap_gpio_show_rev is wrong. > > This removes the __init. > > Signed-off-by: Arnd Bergmann > --- Acked-by: Santosh Shilimkar