Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751466AbdIRWPC (ORCPT ); Mon, 18 Sep 2017 18:15:02 -0400 Received: from mailout.easymail.ca ([64.68.200.34]:32939 "EHLO mailout.easymail.ca" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750886AbdIRWPA (ORCPT ); Mon, 18 Sep 2017 18:15:00 -0400 Reply-To: shuah@kernel.org Subject: Re: [PATCH 2/3] selftests: actually run the various net selftests To: josef@toxicpanda.com Cc: Josef Bacik , "David S. Miller" , linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, netdev@vger.kernel.org, Shuah Khan , Shuah Khan References: <1505755982-7855-1-git-send-email-jbacik@fb.com> <1505755982-7855-2-git-send-email-jbacik@fb.com> From: Shuah Khan Message-ID: <09f17145-5f0a-ec61-3dfb-69216eac7133@kernel.org> Date: Mon, 18 Sep 2017 16:14:41 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <1505755982-7855-2-git-send-email-jbacik@fb.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1376 Lines: 31 On 09/18/2017 11:32 AM, josef@toxicpanda.com wrote: > From: Josef Bacik > > These self tests are just self contained binaries, they are not run by > any of the scripts in the directory. This means they need to be marked > with TEST_GEN_PROGS to actually be run, not TEST_GEN_FILES. > > Signed-off-by: Josef Bacik > --- > tools/testing/selftests/net/Makefile | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/tools/testing/selftests/net/Makefile b/tools/testing/selftests/net/Makefile > index 3df542c84610..45a4e77a47c4 100644 > --- a/tools/testing/selftests/net/Makefile > +++ b/tools/testing/selftests/net/Makefile > @@ -6,8 +6,8 @@ CFLAGS += -I../../../../usr/include/ > TEST_PROGS := run_netsocktests run_afpackettests test_bpf.sh netdevice.sh rtnetlink.sh > TEST_GEN_FILES = socket > TEST_GEN_FILES += psock_fanout psock_tpacket > -TEST_GEN_FILES += reuseport_bpf reuseport_bpf_cpu reuseport_bpf_numa > -TEST_GEN_FILES += reuseport_dualstack msg_zerocopy reuseaddr_conflict > +TEST_GEN_PROGS += reuseport_bpf reuseport_bpf_cpu reuseport_bpf_numa > +TEST_GEN_PROGS += reuseport_dualstack msg_zerocopy reuseaddr_conflict Hmm. I see msg_zerocopy.sh for running msg_zerocopy. msg_zerocopy should still stay in TEST_GEN_FILES and msg_zerocopy.sh needs to be added to TEST_PROGS so it runs. thanks, -- Shuah