Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751416AbdISApp (ORCPT ); Mon, 18 Sep 2017 20:45:45 -0400 Received: from esa6.microchip.iphmx.com ([216.71.154.253]:12862 "EHLO esa6.microchip.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750883AbdISApn (ORCPT ); Mon, 18 Sep 2017 20:45:43 -0400 X-IronPort-AV: E=Sophos;i="5.42,415,1500966000"; d="scan'208";a="4557271" From: To: CC: , , , , , , , Subject: RE: [PATCH RFC 6/6] Modify tag_ksz.c to support other KSZ switch drivers Thread-Topic: [PATCH RFC 6/6] Modify tag_ksz.c to support other KSZ switch drivers Thread-Index: AdMoGgjwWn+O5iRqREClMgoWecPmmwAAub+wABAyfwACFI9x8AAQwOcAAA2JDcD//8R9AIAAb5wg//+gYgCAAG1NEA== Date: Tue, 19 Sep 2017 00:45:41 +0000 Message-ID: <93AF473E2DA327428DE3D46B72B1E9FD41124E47@CHN-SV-EXMX02.mchp-main.com> References: <93AF473E2DA327428DE3D46B72B1E9FD41121901@CHN-SV-EXMX02.mchp-main.com> <93AF473E2DA327428DE3D46B72B1E9FD41121A22@CHN-SV-EXMX02.mchp-main.com> <20170907214834.GT11248@lunn.ch> <93AF473E2DA327428DE3D46B72B1E9FD41124D2E@CHN-SV-EXMX02.mchp-main.com> <20170918195708.GE15606@lunn.ch> <93AF473E2DA327428DE3D46B72B1E9FD41124D7C@CHN-SV-EXMX02.mchp-main.com> <20170918225142.GC29615@lunn.ch> <93AF473E2DA327428DE3D46B72B1E9FD41124E0C@CHN-SV-EXMX02.mchp-main.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.10.215.90] Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by nfs id v8J0jneq004599 Content-Length: 858 Lines: 14 > I am not really sure why this is such a concern for you so soon when > your driver is not even included yet. You should really aim for baby > steps here: get the basic driver(s) included, with a limited set of > features, and gradually add more features to the driver. When > fwd_offload_mark and RSTP become a real problem, we can most > definitively find a way to fix those in DSA and depending drivers. I was under the impression that there is a new push of this new switchdev model and so the DSA model was overhauled to support that. The KSZ9477 driver is already in the kernel, and its register access is actually much different from the other older switches. There are not much common code to be reused. I always know this tail tag handling is the sticking point. I will submit a much simplified driver and wait for switch access in the future.