Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751801AbdISBIm (ORCPT ); Mon, 18 Sep 2017 21:08:42 -0400 Received: from sessmg22.ericsson.net ([193.180.251.58]:55430 "EHLO sessmg22.ericsson.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751778AbdISBIi (ORCPT ); Mon, 18 Sep 2017 21:08:38 -0400 X-AuditID: c1b4fb3a-9e1d49c0000051a3-ea-59c06e149293 From: Jon Maloy To: Joe Perches , Thomas Meyer CC: Ying Xue , "netdev@vger.kernel.org" , "tipc-discussion@lists.sourceforge.net" , "linux-kernel@vger.kernel.org" , "davem@davemloft.net" Subject: RE: [PATCH V2] tipc: Use bsearch library function Thread-Topic: [PATCH V2] tipc: Use bsearch library function Thread-Index: AQHTLsCFggJ6hPSP+EWhjy5rbdPPE6K3N4aAgAAGogCAAALngIAABiAAgAADfYCAAAHhgIAAMg2QgAGvNwCAAA8JwIAAWc4AgAHSd5A= Date: Tue, 19 Sep 2017 01:08:33 +0000 Message-ID: References: <20170911.143025.555018840006192902.davem@davemloft.net> <20170916075036.28676-1-thomas@m3y3r.de> <16128f5e-66ff-b6ec-c0e1-74ea08c212b0@windriver.com> <1505553970.16316.1.camel@perches.com> <64ee51ce-eb7e-ac1c-56a9-9481f6f80b35@windriver.com> <1505555908.16316.5.camel@perches.com> <35f41984-22e9-5adc-0e4d-a4ef4204f6d7@windriver.com> <1505557061.16316.7.camel@perches.com> <760F46A5-2C04-4F3F-83C5-5EA331CFA1D6@m3y3r.de> <1505682926.16316.15.camel@perches.com> In-Reply-To: <1505682926.16316.15.camel@perches.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [212.247.172.218] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;DB5PR0701MB2024;6:X178ABegf9q6J9S4WxjcsX0XbJjd5W5p4Cs5Ua5r9PfOk+gaMUAxa2lB4o7kPUauWE5qyyn9lFgluRngtlx9s9CRfg+hd5DvJC5ixFKhMTG4BreByBGq5i+oT53uNa2zx+N3qfntjAzuz/V3y/vITUDLL9i4bdS20YrHJUAovCDXQm44roU72PzaD4QJnHIhR02nlD68S1gOwCmmwioutUPlG+Dtg225DMllfdzY98lBx48/phpSlz05MpPDHDLXb0sMqa1WPnbEKS+OheZoxPb+6t2sdDngFEU8zjd32ZkEPxzr5ziuEFw8Deeiajz5nixaXFb1QIl3La2sSD4eZA==;5:SDPuDpZCqgZPGRBDXnIzNKP7XI2pgujmqJrlWgGew5M1BCTZFbh18cByYC6eOmJnGw9kwPxifzOtnQ1ADBG1lXLcXo5zW9dBxr79nDEtuMASoe98Emx4KcII08kjTNoCz+Y9u7mfyDZI7TWG/2iBpQ==;24:tvxP2ZsN7RdQT0NkZDaa8j0R4HDZoLsJQmUE/bOBQ1ma2zpNegq+PvthjvfpVm4AZAIwwygFu1U2DyTtCFAqP/HeyeF/yHNkNYj69pcaNGc=;7:AHEslltZNhxaXWnE1PTkudtKRSspihIKDMxQoZ5seqKgW0844xd636PzVBiWsizvD0wTPHeEzJkXT8+z5stufVoOIk0kDotiuWCvVQ8VX+CTKDsy1aHKX7JSr7vmWvsKWeHYESwKwavwZAOyX4V/Hw3vu0D6TIayQsIHSIR8noAM570jv6RvGUKCx+OPsogT41WIODYMzIBs2tYrHIZyoMhUqcWHQtOusv/6NjaZVkk= x-ms-exchange-antispam-srfa-diagnostics: SSOS; x-ms-office365-filtering-correlation-id: 99c08c4d-d013-4559-e3bc-08d4fefaf31f x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(300000503095)(300135400095)(2017052603199)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095);SRVR:DB5PR0701MB2024; x-ms-traffictypediagnostic: DB5PR0701MB2024: authentication-results: spf=none (sender IP is ) smtp.mailfrom=jon.maloy@ericsson.com; x-ld-processed: 92e84ceb-fbfd-47ab-be52-080c6b87953f,ExtAddr x-exchange-antispam-report-test: UriScan:(37575265505322)(143289334528602)(9452136761055)(42262312472803); x-microsoft-antispam-prvs: x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(5005006)(8121501046)(10201501046)(3002001)(93006095)(93001095)(100000703101)(100105400095)(6041248)(20161123562025)(20161123558100)(20161123560025)(20161123564025)(20161123555025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:DB5PR0701MB2024;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:DB5PR0701MB2024; x-forefront-prvs: 04359FAD81 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(6009001)(39860400002)(346002)(376002)(377424004)(189002)(24454002)(199003)(13464003)(6116002)(3280700002)(2900100001)(5250100002)(229853002)(14454004)(8936002)(305945005)(33656002)(106356001)(97736004)(3660700001)(25786009)(5660300001)(7736002)(189998001)(8676002)(3846002)(102836003)(105586002)(478600001)(66066001)(4326008)(7696004)(110136005)(53546010)(2906002)(9686003)(53936002)(81166006)(6246003)(99286003)(55016002)(54906002)(54356999)(50986999)(76176999)(6436002)(316002)(6506006)(101416001)(81156014)(2950100002)(93886005)(68736007)(74316002)(86362001);DIR:OUT;SFP:1101;SCL:1;SRVR:DB5PR0701MB2024;H:DB5PR0701MB1958.eurprd07.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Sep 2017 01:08:33.9533 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 92e84ceb-fbfd-47ab-be52-080c6b87953f X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB5PR0701MB2024 X-OriginatorOrg: ericsson.com X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrGKsWRmVeSWpSXmKPExsUyM2K7ga5I3oFIg/OH1C3mnG9hsZh9/zGL xeVdc9gsji0Qs7i2YDqjxZbzWQ5sHltW3mTy2L3gM5PHvP+32Dy+rLrG7PF5k1wAaxSXTUpq TmZZapG+XQJXxv+L1QXfOCta7xxmbGDs5ehi5OSQEDCRaN6zkbWLkYtDSOAIo8Tp2x3MEM4J Rom5X78ygjgsAr3MEi2bW1hAWoQE5jJJtO7Xgah6zigxYedqNpAEm4CGxMtpHYwgtoiAo8TW jy1g3cwCs5kkdjw7AFYkLGAlsXnvOTaIImuJnt5DUA1lEk+XtIHZLAKqEqunQGzjFUiQ2Dr3 KzvEtpesEi/b77KCJDiBLn9ythfMZhQQk/h+ag0TiM0sIC5x68l8JojvBCSW7DnPDGGLSrx8 /I8VwlaWWLH/OFRcVuLS/G6wSyUEOtglmq/uZYFI6ElsnfiWEcL2lTj6YjIrRNETJolN32ax QyR0JJ5P+wPUwAF0RaTE6aeREGEbiRnd06EWZEmcWt8PVZ4vsW7DVqg551klHn84zD6BUW8W ksMhbB2JBbs/sUHY2hLLFr5mngUODUGJkzOfsCxgZFnFKFqcWlycm25kpJdalJlcXJyfp5eX WrKJEZh6Dm75bbWD8eBzx0OMAhyMSjy8ymYHIoVYE8uKK3MPMUpwMCuJ8NrHAIV4UxIrq1KL 8uOLSnNSiw8xSnOwKInzOuy7ECEkkJ5YkpqdmlqQWgSTZeLglGpgZHT/b2bAuYr50e0Ww8m3 mbPlbx45FenwOMPrvISpwH2555O4flYz9OcavDkf+/Ke/qbKNVde+qbFGHddPHnbPF9GTqFJ t3T3rPfXbALTdJ5etbyxYMUNeTWXeX8MK/01H5zxK7RhtarP+zz9653KxoDvEyf6bTJ1L9z1 oOLbErEFqez/JB94KrEUZyQaajEXFScCAEoEMVM5AwAA Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by nfs id v8J19AYC008139 Content-Length: 1233 Lines: 31 > -----Original Message----- > From: netdev-owner@vger.kernel.org [mailto:netdev- > owner@vger.kernel.org] On Behalf Of Joe Perches > Sent: Sunday, September 17, 2017 23:15 > To: Jon Maloy ; Thomas Meyer > > Cc: Ying Xue ; netdev@vger.kernel.org; tipc- > discussion@lists.sourceforge.net; linux-kernel@vger.kernel.org; > davem@davemloft.net > Subject: Re: [PATCH V2] tipc: Use bsearch library function > > On Sun, 2017-09-17 at 16:27 +0000, Jon Maloy wrote: > > > -----Original Message----- > > > From: Thomas Meyer [mailto:thomas@m3y3r.de] > [] > > > What about the other binary search implementation in the same file? > > > Should I try to convert it it will it get NAKed for performance reasons too? > > > > The searches for inserting and removing publications is less time > > critical, so that would be ok with me. > > If you have any more general interest in improving the code in this > > file (which is needed) it would also be appreciated. > > Perhaps using an rbtree would be an improvement. Not a bad idea. It would probably reduce the code amount, possibly at the expense of cache hit rate during the binary lookup. It is worth looking into. ///jon