From: Jon Maloy <jon.maloy@ericsson.com>
To: Joe Perches <joe@perches.com>, Thomas Meyer <thomas@m3y3r.de>
CC: Ying Xue <ying.xue@windriver.com>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "tipc-discussion@lists.sourceforge.net" 
        <tipc-discussion@lists.sourceforge.net>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "davem@davemloft.net" <davem@davemloft.net>
Subject: RE: [PATCH V2] tipc: Use bsearch library function
Thread-Topic: [PATCH V2] tipc: Use bsearch library function
Thread-Index: AQHTLsCFggJ6hPSP+EWhjy5rbdPPE6K3N4aAgAAGogCAAALngIAABiAAgAADfYCAAAHhgIAAMg2QgAGvNwCAAA8JwIAAWc4AgAHSd5A=
Date: Tue, 19 Sep 2017 01:08:33 +0000
Message-ID: <DB5PR0701MB1958240FB878DD084D0BA4C49A600@DB5PR0701MB1958.eurprd07.prod.outlook.com>
References: <20170911.143025.555018840006192902.davem@davemloft.net>
         <20170916075036.28676-1-thomas@m3y3r.de>
         <16128f5e-66ff-b6ec-c0e1-74ea08c212b0@windriver.com>
         <1505553970.16316.1.camel@perches.com>
         <64ee51ce-eb7e-ac1c-56a9-9481f6f80b35@windriver.com>
         <1505555908.16316.5.camel@perches.com>
         <35f41984-22e9-5adc-0e4d-a4ef4204f6d7@windriver.com>
         <1505557061.16316.7.camel@perches.com>
         <DB5PR0701MB1958558286B3B455C601754A9A6D0@DB5PR0701MB1958.eurprd07.prod.outlook.com>
         <760F46A5-2C04-4F3F-83C5-5EA331CFA1D6@m3y3r.de>
         <DB5PR0701MB195892D3D60DAB5D7C1109AE9A620@DB5PR0701MB1958.eurprd07.prod.outlook.com>
 <1505682926.16316.15.camel@perches.com>
In-Reply-To: <1505682926.16316.15.camel@perches.com>
Accept-Language: en-US
Content-Language: en-US
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Sep 2017 01:08:33.9533
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 92e84ceb-fbfd-47ab-be52-080c6b87953f
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB5PR0701MB2024
X-OriginatorOrg: ericsson.com
X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrGKsWRmVeSWpSXmKPExsUyM2K7ga5I3oFIg/OH1C3mnG9hsZh9/zGL
        xeVdc9gsji0Qs7i2YDqjxZbzWQ5sHltW3mTy2L3gM5PHvP+32Dy+rLrG7PF5k1wAaxSXTUpq
        TmZZapG+XQJXxv+L1QXfOCta7xxmbGDs5ehi5OSQEDCRaN6zkbWLkYtDSOAIo8Tp2x3MEM4J
        Rom5X78ygjgsAr3MEi2bW1hAWoQE5jJJtO7Xgah6zigxYedqNpAEm4CGxMtpHYwgtoiAo8TW
        jy1g3cwCs5kkdjw7AFYkLGAlsXnvOTaIImuJnt5DUA1lEk+XtIHZLAKqEqunQGzjFUiQ2Dr3
        KzvEtpesEi/b77KCJDiBLn9ythfMZhQQk/h+ag0TiM0sIC5x68l8JojvBCSW7DnPDGGLSrx8
        /I8VwlaWWLH/OFRcVuLS/G6wSyUEOtglmq/uZYFI6ElsnfiWEcL2lTj6YjIrRNETJolN32ax
        QyR0JJ5P+wPUwAF0RaTE6aeREGEbiRnd06EWZEmcWt8PVZ4vsW7DVqg551klHn84zD6BUW8W
        ksMhbB2JBbs/sUHY2hLLFr5mngUODUGJkzOfsCxgZFnFKFqcWlycm25kpJdalJlcXJyfp5eX
        WrKJEZh6Dm75bbWD8eBzx0OMAhyMSjy8ymYHIoVYE8uKK3MPMUpwMCuJ8NrHAIV4UxIrq1KL
        8uOLSnNSiw8xSnOwKInzOuy7ECEkkJ5YkpqdmlqQWgSTZeLglGpgZHT/b2bAuYr50e0Ww8m3
        mbPlbx45FenwOMPrvISpwH2555O4flYz9OcavDkf+/Ke/qbKNVde+qbFGHddPHnbPF9GTqFJ
        t3T3rPfXbALTdJ5etbyxYMUNeTWXeX8MK/01H5zxK7RhtarP+zz9653KxoDvEyf6bTJ1L9z1
        oOLbErEFqez/JB94KrEUZyQaajEXFScCAEoEMVM5AwAA
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Transfer-Encoding: 8bit
X-MIME-Autoconverted: from quoted-printable to 8bit by nfs id v8J19AYC008139
Content-Length: 1233
Lines: 31


> -----Original Message-----
> From: netdev-owner@vger.kernel.org [mailto:netdev-
> owner@vger.kernel.org] On Behalf Of Joe Perches
> Sent: Sunday, September 17, 2017 23:15
> To: Jon Maloy <jon.maloy@ericsson.com>; Thomas Meyer
> <thomas@m3y3r.de>
> Cc: Ying Xue <ying.xue@windriver.com>; netdev@vger.kernel.org; tipc-
> discussion@lists.sourceforge.net; linux-kernel@vger.kernel.org;
> davem@davemloft.net
> Subject: Re: [PATCH V2] tipc: Use bsearch library function
> 
> On Sun, 2017-09-17 at 16:27 +0000, Jon Maloy wrote:
> > > -----Original Message-----
> > > From: Thomas Meyer [mailto:thomas@m3y3r.de]
> []
> > > What about the other binary search implementation in the same file?
> > > Should I try to convert it it will it get NAKed for performance reasons too?
> >
> > The searches for inserting and removing publications is less time
> > critical, so that would be ok with me.
> > If you have any more general interest in improving the code in this
> > file (which is needed) it would also be appreciated.
> 
> Perhaps using an rbtree would be an improvement.

Not a bad idea. It would probably reduce the code amount, possibly at the expense of cache hit rate during the binary lookup.
It is worth looking into.

///jon