Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751397AbdISD7F (ORCPT ); Mon, 18 Sep 2017 23:59:05 -0400 Received: from mail.kernel.org ([198.145.29.99]:60436 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751210AbdISD7E (ORCPT ); Mon, 18 Sep 2017 23:59:04 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0FD5E2168C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=leon@kernel.org Date: Tue, 19 Sep 2017 06:59:00 +0300 From: Leon Romanovsky To: Salil Mehta Cc: davem@davemloft.net, yisen.zhuang@huawei.com, lipeng321@huawei.com, mehta.salil.lnk@gmail.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org, linuxarm@huawei.com Subject: Re: [PATCH net 0/7] Bug fixes for the HNS3 Ethernet Driver for Hip08 SoC Message-ID: <20170919035900.GI5788@mtr-leonro.local> References: <20170919010628.175732-1-salil.mehta@huawei.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="7SAgGoIHugoKhRwh" Content-Disposition: inline In-Reply-To: <20170919010628.175732-1-salil.mehta@huawei.com> User-Agent: Mutt/1.9.0 (2017-09-02) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2348 Lines: 63 --7SAgGoIHugoKhRwh Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Sep 19, 2017 at 02:06:21AM +0100, Salil Mehta wrote: > This patch set presents some bug fixes for the HNS3 Ethernet driver, identified > during internal testing & stabilization efforts. > > This patch series is meant for Linux 4.14 kernel. > > Lipeng (6): > net: hns3: get phy addr from NCL_config > net: hns3: fix the command used to unmap ring from vector > net: hns3: Fix ring and vector map command > net: hns3: fix a bug of set mac address > net: hns3: set default vlan id to PF > net: hns3: Fixes the premature exit of loop when matching clients > > Salil Mehta (1): > net: hns3: fixes the ether address copy with more appropriate API 1. The fixes patches should have Fixes line and not all of them have (I didn't look all patches). 2. Please decide on one style: fixes vs. Fixes, fix vs. Fix in the titles 3. Subject should be descriptive and usable, I don't know if it applies to the "fix a bug of set mac address" patch. Thanks > > drivers/net/ethernet/hisilicon/hns3/hnae3.c | 43 +++++----------------- > .../net/ethernet/hisilicon/hns3/hns3pf/hclge_cmd.h | 8 +++- > .../ethernet/hisilicon/hns3/hns3pf/hclge_main.c | 20 ++++++++-- > .../net/ethernet/hisilicon/hns3/hns3pf/hns3_enet.c | 7 ++-- > 4 files changed, 35 insertions(+), 43 deletions(-) > > -- > 2.11.0 > > --7SAgGoIHugoKhRwh Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEkhr/r4Op1/04yqaB5GN7iDZyWKcFAlnAlgQACgkQ5GN7iDZy WKeIyA/9ESkbcwj0SNqY874YioMFgm7CpXddZfQawm5rv8PHAk1eiIuG80XXQZfd uerudhuw5bHeXnhYrQ64bB8CwHNAXb4sD8CUkXXAO5Nc3QcxL5KCfKhFO4YynsCA 40LqXqqkNNTvDBRt89YAfdvdLonPo+WL0sB4rVCmv/LpvVIgFDWqN2vDldL4EUKi 27WurhHoeyFTLc9YeNddfk5kLXlO4526BLEMb485q3eZC6HDaq26kaMJwxhCYgq/ 4t+T2JPLvDE/tmrqFcTHJ9ciMovLrzbEilRGIQNPZ2nFHYDhh7JmKC48b207C4vr 4569NRdTrfzRdiNvqHLUE7cPKPFv611+a4lik9zcBerr1583wmuFhvnyzn4HY00i ykSF4iCO+mNuQ5OpPTYsfeatrJlBlAnwBAMWN8QyCOFXM3qiZacxalnxxV94mXft dVF5pc80+U4Oeqo0b3/8ZLIglQb5JdF3ptAvYNYo7Xh4Mrv6UOoKLUYl59/DyDKv lvBvk2i+acDej/4R7E+BwDIM72AbM0HGRyUaxZpMOvNsmC1kHaYHPD457N30hHzc 0vDnnEcX06rABD1eWgK+9E9DYo1zMh0Ll0nrB+mQYkE6nuQ/7dU/PS85UFksgDik Wsg1N2xPm30GABXKLjdZSb8XOyQmydyYnBUxPS3niR/E3Zeq/Vc= =+9ih -----END PGP SIGNATURE----- --7SAgGoIHugoKhRwh--