Date: Tue, 19 Sep 2017 10:12:39 +0300
From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        "David S . Miller" <davem@davemloft.net>,
        Andreas Noever <andreas.noever@gmail.com>,
        Michael Jamet <michael.jamet@intel.com>,
        Yehezkel Bernat <yehezkel.bernat@intel.com>,
        Amir Levy <amir.jer.levy@intel.com>, Mario.Limonciello@dell.com,
        Lukas Wunner <lukas@wunner.de>,
        Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH 16/16] thunderbolt: Add support for networking over
 Thunderbolt cable
Message-ID: <20170919071239.GB4630@lahna.fi.intel.com>
References: <20170918153049.44185-1-mika.westerberg@linux.intel.com>
 <20170918153049.44185-17-mika.westerberg@linux.intel.com>
 <20170918232144.GD29615@lunn.ch>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20170918232144.GD29615@lunn.ch>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
User-Agent: Mutt/1.8.3 (2017-05-23)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 2363
Lines: 51

On Tue, Sep 19, 2017 at 01:21:44AM +0200, Andrew Lunn wrote:
> On Mon, Sep 18, 2017 at 06:30:49PM +0300, Mika Westerberg wrote:
> > From: Amir Levy <amir.jer.levy@intel.com>
> > 
> > ThunderboltIP is a protocol created by Apple to tunnel IP/ethernet
> > traffic over a Thunderbolt cable. The protocol consists of configuration
> > phase where each side sends ThunderboltIP login packets (the protocol is
> > determined by UUID in the XDomain packet header) over the configuration
> > channel. Once both sides get positive acknowledgment to their login
> > packet, they configure high-speed DMA path accordingly. This DMA path is
> > then used to transmit and receive networking traffic.
> > 
> > This patch creates a virtual ethernet interface the host software can
> > use in the same way as any other networking interface. Once the
> > interface is brought up successfully network packets get tunneled over
> > the Thunderbolt cable to the remote host and back.
> > 
> > The connection is terminated by sending a ThunderboltIP logout packet
> > over the configuration channel. We do this when the network interface is
> > brought down by user or the driver is unloaded.
> > 
> > Signed-off-by: Amir Levy <amir.jer.levy@intel.com>
> > Signed-off-by: Michael Jamet <michael.jamet@intel.com>
> > Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
> > Reviewed-by: Yehezkel Bernat <yehezkel.bernat@intel.com>
> > ---
> >  Documentation/admin-guide/thunderbolt.rst |   24 +
> >  drivers/thunderbolt/Kconfig               |   12 +
> >  drivers/thunderbolt/Makefile              |    3 +
> >  drivers/thunderbolt/net.c                 | 1392 +++++++++++++++++++++++++++++
> >  4 files changed, 1431 insertions(+)
> >  create mode 100644 drivers/thunderbolt/net.c
> 
> Hi Mika
> 
> Could this be renamed to driver/net/thunderbolt.c?

I pondered between drivers/thunderbolt/net.c and
drivers/net/thunderbolt.c and then decided to go with the former because
it follows drivers/firewire/net.c and kind of makes it easier for user
to enabled.

But no problem moving it into drivers/net if that's what networking
people prefer.

> At minimum, it needs a MAINTAINER entry pointing to netdev, so patches
> get reviewed by netdev people. However, since the driver seems to be a
> lot more netdev than thunderbolt, placing it in driver/net could be
> better.

OK.