Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751594AbdISIUn (ORCPT ); Tue, 19 Sep 2017 04:20:43 -0400 Received: from mail-it0-f41.google.com ([209.85.214.41]:53865 "EHLO mail-it0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751551AbdISIUl (ORCPT ); Tue, 19 Sep 2017 04:20:41 -0400 X-Google-Smtp-Source: AOwi7QAenUtA3bI51JcdRU5ac+D8KTIpds9DWo5D1JntXv5SCHvY1YD+nIBt9/zwoysRIdAXiT3x8DczhYrseJLmfck= MIME-Version: 1.0 In-Reply-To: <20170912003331.3092-1-fenglinw@codeaurora.org> References: <20170912003331.3092-1-fenglinw@codeaurora.org> From: Linus Walleij Date: Tue, 19 Sep 2017 10:20:39 +0200 Message-ID: Subject: Re: [PATCH V1] pinctrl: qcom: spmi-gpio: Update GPIO EN_CTL when setting pin config To: fenglinw@codeaurora.org, Bjorn Andersson Cc: "linux-arm-msm@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-gpio@vger.kernel.org" , David Collins , aghayal@codeaurora.org, wruan@codeaurora.org, subbaram@codeaurora.org, kgunda@codeaurora.org, Ivan Ivanov Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by nfs id v8J8KkWf001090 Content-Length: 503 Lines: 15 On Tue, Sep 12, 2017 at 2:32 AM, wrote: > From: Fenglin Wu > > GPIO is expected to be disabled iff PIN_CONFIG_BIAS_HIGH_IMPEDANCE is > configured. Update is_enabled flag in config_set() so that it can > reflect GPIO status correctly. Also modify EN_CTL register based on > is_enabled flag in config_set() to configure the GPIO properly. > > Signed-off-by: Fenglin Wu Pending on Björn's review here. Yours, Linus Walleij