Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751611AbdISMJM (ORCPT ); Tue, 19 Sep 2017 08:09:12 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:16651 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751471AbdISMJL (ORCPT ); Tue, 19 Sep 2017 08:09:11 -0400 Date: Tue, 19 Sep 2017 15:08:52 +0300 From: Dan Carpenter To: Benjamin Gaignard Cc: Greg KH , driverdevel , Arve =?iso-8859-1?B?SGr4bm5lduVn?= , Linux Kernel Mailing List , Riley Andrews , Mark Brown , Sumit Semwal Subject: Re: [PATCH v2 2/2] staging: ion: create one device entry per heap Message-ID: <20170919120852.mghjnf3sytuzcoi4@mwanda> References: <1505816738-30017-1-git-send-email-benjamin.gaignard@linaro.org> <1505816738-30017-3-git-send-email-benjamin.gaignard@linaro.org> <20170919110254.GB4511@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) X-Source-IP: userv0021.oracle.com [156.151.31.71] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 182 Lines: 6 If you had spelled out how this patch breaks user space in the changelog then you wouldn't be catching so much flak for it now... You should fix that in v3. regards, dan carpenter