Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751750AbdISM1S (ORCPT ); Tue, 19 Sep 2017 08:27:18 -0400 Received: from mx1.redhat.com ([209.132.183.28]:35244 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751516AbdISM1Q (ORCPT ); Tue, 19 Sep 2017 08:27:16 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com CB9B97EA94 Authentication-Results: ext-mx04.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx04.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=jolsa@redhat.com Date: Tue, 19 Sep 2017 14:27:11 +0200 From: Jiri Olsa To: Milian Wolff Cc: acme@kernel.org, jolsa@kernel.org, Jin Yao , Linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, Arnaldo Carvalho de Melo , David Ahern , Namhyung Kim , Peter Zijlstra Subject: Re: [PATCH v3 03/13] perf report: create real callchain entries for inlined frames Message-ID: <20170919122711.GA13388@krava> References: <20170906135501.306-1-milian.wolff@kdab.com> <20170906135501.306-4-milian.wolff@kdab.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170906135501.306-4-milian.wolff@kdab.com> User-Agent: Mutt/1.9.0 (2017-09-02) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Tue, 19 Sep 2017 12:27:16 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 858 Lines: 22 On Wed, Sep 06, 2017 at 03:54:51PM +0200, Milian Wolff wrote: SNIP > > -struct inline_node *dso__parse_addr_inlines(struct dso *dso, u64 addr); > +// parse inlined frames for the given address > +struct inline_node *dso__parse_addr_inlines(struct dso *dso, u64 addr, > + struct symbol *sym); > +// free resources associated to the inline node list > void inline_node__delete(struct inline_node *node); > > +// insert the inline node list into the DSO, which will take ownership > +void inlines__tree_insert(struct rb_root *tree, struct inline_node *inlines); > +// find previously inserted inline node list > +struct inline_node *inlines__tree_find(struct rb_root *tree, u64 addr); > +// delete all nodes within the tree of inline_node s > +void inlines__tree_delete(struct rb_root *tree); nit, think we prefer the /* */ comment style jirka