Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751377AbdISNMl (ORCPT ); Tue, 19 Sep 2017 09:12:41 -0400 Received: from mail-wr0-f171.google.com ([209.85.128.171]:56305 "EHLO mail-wr0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750823AbdISNMk (ORCPT ); Tue, 19 Sep 2017 09:12:40 -0400 X-Google-Smtp-Source: AOwi7QDYSIVfIEJNcqyiyNUdbCFQEX/hXFIrHYXkvlb73uJYVZAHYmv0wbMnbcaZ+T1+q+9giUG3jg== Date: Tue, 19 Sep 2017 15:12:34 +0200 From: Seraphime Kirkovski To: Stefan =?iso-8859-1?Q?M=E4tje?= Cc: "linux-kernel@vger.kernel.org" Subject: Re: linux-4.14-rc1/arch/x86/include/asm/uaccess.h: Missing include of Message-ID: <20170919131234.7eznipb6b76lwo7u@macchiaveli> References: <371328dc-0cd7-8747-e189-cfa7005d5555@esd.eu> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <371328dc-0cd7-8747-e189-cfa7005d5555@esd.eu> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 643 Lines: 32 Hi, > ./arch/x86/include/asm/uaccess.h: In function ‘set_fs’: > ./arch/x86/include/asm/uaccess.h:31:9: error: dereferencing pointer to > incomplete type I can reproduce your problem by including , but not with . #include //#include does compile #include int __init init(void) { set_fs(get_fs()); return 0; } void __exit finit(void) { } module_init(init); module_exit(finit); If my memory is any good, direct inclusion of was deprecated in 4.12 and new code should use Thanks, Seraphime Kirkovski