Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751543AbdISNgi (ORCPT ); Tue, 19 Sep 2017 09:36:38 -0400 Received: from mail.kernel.org ([198.145.29.99]:47822 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751408AbdISNgg (ORCPT ); Tue, 19 Sep 2017 09:36:36 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9C62522A85 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=robh+dt@kernel.org X-Google-Smtp-Source: AOwi7QBONI8ENiJdOO2wAjMyIvSKjnApC9IcYjKqnFsi7fh7RfiXvvwSeTvMc3dn3g9W6sKSCeaCh+iw1Dds4SPYVrw= MIME-Version: 1.0 In-Reply-To: <20170918205005.30235-2-afd@ti.com> References: <20170918205005.30235-1-afd@ti.com> <20170918205005.30235-2-afd@ti.com> From: Rob Herring Date: Tue, 19 Sep 2017 08:36:07 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 2/2] tee: optee: allow selection of ti-smc as a calling method To: "Andrew F. Davis" Cc: Mark Rutland , Russell King , Jens Wiklander , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1373 Lines: 29 On Mon, Sep 18, 2017 at 3:50 PM, Andrew F. Davis wrote: > On TI platforms OP-TEE must be called using a modified SMC call, > allow the selection of this though DT. > > Signed-off-by: Andrew F. Davis > --- > Documentation/devicetree/bindings/arm/firmware/linaro,optee-tz.txt | 2 ++ > drivers/tee/optee/core.c | 2 ++ > 2 files changed, 4 insertions(+) > > diff --git a/Documentation/devicetree/bindings/arm/firmware/linaro,optee-tz.txt b/Documentation/devicetree/bindings/arm/firmware/linaro,optee-tz.txt > index d38834c67dff..a3275ecdf186 100644 > --- a/Documentation/devicetree/bindings/arm/firmware/linaro,optee-tz.txt > +++ b/Documentation/devicetree/bindings/arm/firmware/linaro,optee-tz.txt > @@ -20,6 +20,8 @@ the reference implementation maintained by Linaro. > "hvc" : HVC #0, with the register assignments specified > in drivers/tee/optee/optee_smc.h > > + "ti-smc" : Similar to "smc" with TI specific register > + adjustments Sigh, really? IMO, this should be determined from the compatible string. Then the next TI (or any vendor) specific thing can be handled without a DT change. Maybe some day we'll figure out that not just h/w needs to be probe-able, but all the firmware pieces do too. Rob