Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751462AbdISN5K (ORCPT <rfc822;w@1wt.eu>);
        Tue, 19 Sep 2017 09:57:10 -0400
Received: from mxp02.htp-tel.de ([212.59.41.9]:41772 "EHLO mxpout02.htp-tel.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1751034AbdISN5J (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 19 Sep 2017 09:57:09 -0400
Subject: Re: linux-4.14-rc1/arch/x86/include/asm/uaccess.h: Missing include of
 <linux/sched.h>
To: Seraphime Kirkovski <kirkseraph@gmail.com>
CC: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
References: <371328dc-0cd7-8747-e189-cfa7005d5555@esd.eu>
 <20170919131234.7eznipb6b76lwo7u@macchiaveli>
From: =?UTF-8?Q?Stefan_M=c3=a4tje?= <Stefan.Maetje@esd.eu>
Message-ID: <1017211f-607c-56fa-104f-0b1f49ebac40@esd.eu>
Date: Tue, 19 Sep 2017 15:57:05 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.3.0
MIME-Version: 1.0
In-Reply-To: <20170919131234.7eznipb6b76lwo7u@macchiaveli>
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: 8bit
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.4.3 (mxpin02.htp-tel.de [172.19.12.5]); Tue, 19 Sep 2017 15:57:06 +0200 (CEST)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 840
Lines: 33

Hi,

changing the include line to <linux/uaccess.h> solves the problem for me.

Thank you for taking the time to look into this.

Best regards,
	Stefan Mätje

Am 19.09.2017 um 15:12 schrieb Seraphime Kirkovski:
> Hi,
> 
>> ./arch/x86/include/asm/uaccess.h: In function ‘set_fs’:
>> ./arch/x86/include/asm/uaccess.h:31:9: error: dereferencing pointer to
>> incomplete type
> 
> I can reproduce your problem by including <asm/uaccess.h>, but not with 
> <linux/uaccess.h>.
> 
> 	#include <asm/uaccess.h>
> 	//#include <linux/uaccess.h> does compile
> 	#include <linux/module.h>

My code doesn't use set_fs() but it is only in the header.

> If my memory is any good, direct inclusion of <asm/uaccess.h> was 
> deprecated in 4.12 and new code should use <linux/uaccess.h>

I did miss this deprecation.

> Thanks,
> Seraphime Kirkovski
>