Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751611AbdISONF convert rfc822-to-8bit (ORCPT ); Tue, 19 Sep 2017 10:13:05 -0400 Received: from lhrrgout.huawei.com ([194.213.3.17]:35677 "EHLO lhrrgout.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751284AbdISOND (ORCPT ); Tue, 19 Sep 2017 10:13:03 -0400 From: Salil Mehta To: Leon Romanovsky CC: "davem@davemloft.net" , "Zhuangyuzeng (Yisen)" , "lipeng (Y)" , "mehta.salil.lnk@gmail.com" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-rdma@vger.kernel.org" , Linuxarm Subject: RE: [PATCH net 0/7] Bug fixes for the HNS3 Ethernet Driver for Hip08 SoC Thread-Topic: [PATCH net 0/7] Bug fixes for the HNS3 Ethernet Driver for Hip08 SoC Thread-Index: AQHTMOOjVvz6itsNQUOzTYsI3uoCiaK7c/EAgADMgNA= Date: Tue, 19 Sep 2017 14:12:49 +0000 Message-ID: References: <20170919010628.175732-1-salil.mehta@huawei.com> <20170919035900.GI5788@mtr-leonro.local> In-Reply-To: <20170919035900.GI5788@mtr-leonro.local> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.203.181.154] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A020202.59C125EC.0224,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=169.254.1.161, so=2013-06-18 04:22:30, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: 77a09da0e44a48a681cdc9efde3a519e Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1869 Lines: 54 Hi Leon, > -----Original Message----- > From: Leon Romanovsky [mailto:leon@kernel.org] > Sent: Tuesday, September 19, 2017 4:59 AM > To: Salil Mehta > Cc: davem@davemloft.net; Zhuangyuzeng (Yisen); lipeng (Y); > mehta.salil.lnk@gmail.com; netdev@vger.kernel.org; linux- > kernel@vger.kernel.org; linux-rdma@vger.kernel.org; Linuxarm > Subject: Re: [PATCH net 0/7] Bug fixes for the HNS3 Ethernet Driver for > Hip08 SoC > > On Tue, Sep 19, 2017 at 02:06:21AM +0100, Salil Mehta wrote: > > This patch set presents some bug fixes for the HNS3 Ethernet driver, > identified > > during internal testing & stabilization efforts. > > > > This patch series is meant for Linux 4.14 kernel. > > > > Lipeng (6): > > net: hns3: get phy addr from NCL_config > > net: hns3: fix the command used to unmap ring from vector > > net: hns3: Fix ring and vector map command > > net: hns3: fix a bug of set mac address > > net: hns3: set default vlan id to PF > > net: hns3: Fixes the premature exit of loop when matching clients > > > > Salil Mehta (1): > > net: hns3: fixes the ether address copy with more appropriate API > > 1. The fixes patches should have Fixes line and not all of them have > (I didn't look all patches). > 2. Please decide on one style: fixes vs. Fixes, fix vs. Fix in the > titles > 3. Subject should be descriptive and usable, I don't know if it applies > to the "fix a bug of set mac address" patch. Yes, missed these. Will fix them. Thanks! Salil > > Thanks > > > > > drivers/net/ethernet/hisilicon/hns3/hnae3.c | 43 +++++------- > ---------- > > .../net/ethernet/hisilicon/hns3/hns3pf/hclge_cmd.h | 8 +++- > > .../ethernet/hisilicon/hns3/hns3pf/hclge_main.c | 20 ++++++++-- > > .../net/ethernet/hisilicon/hns3/hns3pf/hns3_enet.c | 7 ++-- > > 4 files changed, 35 insertions(+), 43 deletions(-) > > > > -- > > 2.11.0 > > > >