Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751773AbdISPJ1 (ORCPT ); Tue, 19 Sep 2017 11:09:27 -0400 Received: from fllnx209.ext.ti.com ([198.47.19.16]:36047 "EHLO fllnx209.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751309AbdISPJ0 (ORCPT ); Tue, 19 Sep 2017 11:09:26 -0400 Subject: Re: [PATCH] cpufreq: dt-platdev: Add devices covered by ti-cpufreq to blacklist To: Viresh Kumar References: <20170919145730.8981-1-d-gerlach@ti.com> CC: "Rafael J . Wysocki" , Linux Kernel Mailing List , "linux-arm-kernel@lists.infradead.org" , linux-omap , "linux-pm@vger.kernel.org" , Tony Lindgren From: Dave Gerlach Message-ID: <95578149-903c-a063-ef75-3dae24646e97@ti.com> Date: Tue, 19 Sep 2017 10:08:00 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [128.247.59.203] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1978 Lines: 46 On 09/19/2017 10:02 AM, Viresh Kumar wrote: > On 19 September 2017 at 07:57, Dave Gerlach wrote: >> Commit edeec420de24 ("cpufreq: dt-platdev: Automatically create cpufreq >> device with OPP v2") causes a cpufreq-dt platform device to be >> automatically created for any platform with an OPP v2 node defined. >> However, ti-cpufreq registers the cpufreq-dt platdev at the end of probe >> in order to ensure the ti-cpufreq driver probes first and provides the >> necessary opp-supported-hw for cpufreq-dt. With this new patch now a >> dupluicate cpufreq-dt is created, which we do not want. To avoid this, >> add the platforms handled by ti-cpufreq to the blacklist provided in the >> aforementioned commit to allow ti-cpufreq to continue creating the >> cpufreq-dt platdev. >> >> This applies to am335x, am437x, dra7xx, and am57xx. >> >> Fixes: edeec420de24 ("cpufreq: dt-cpufreq: platdev Automatically create device with OPP v2") >> Signed-off-by: Dave Gerlach >> --- >> drivers/cpufreq/cpufreq-dt-platdev.c | 4 ++++ >> 1 file changed, 4 insertions(+) >> >> diff --git a/drivers/cpufreq/cpufreq-dt-platdev.c b/drivers/cpufreq/cpufreq-dt-platdev.c >> index a020da7940d6..c6f554ba9bb3 100644 >> --- a/drivers/cpufreq/cpufreq-dt-platdev.c >> +++ b/drivers/cpufreq/cpufreq-dt-platdev.c >> @@ -106,6 +106,10 @@ static const struct of_device_id whitelist[] __initconst = { >> * platforms using "operating-points-v2" property. >> */ >> static const struct of_device_id blacklist[] __initconst = { >> + { .compatible = "ti,am33xx", }, >> + { .compatible = "ti,am43", }, >> + { .compatible = "ti,dra7", }, >> + >> { } >> }; > > Perhaps you should ask Sunil to improve his patch. > > https://marc.info/?l=linux-kernel&m=150576233031387&w=2 > Ah, did not see that. Somebody added me to a thread last week about this and I just got around to making a fix now, I will jump on to that thread thanks. Regards, Dave