Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751739AbdISPzN (ORCPT ); Tue, 19 Sep 2017 11:55:13 -0400 Received: from lelnx194.ext.ti.com ([198.47.27.80]:25678 "EHLO lelnx194.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750864AbdISPzL (ORCPT ); Tue, 19 Sep 2017 11:55:11 -0400 Subject: Re: [PATCH 2/2] tee: optee: allow selection of ti-smc as a calling method To: Rob Herring CC: Mark Rutland , Russell King , Jens Wiklander , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" References: <20170918205005.30235-1-afd@ti.com> <20170918205005.30235-2-afd@ti.com> From: "Andrew F. Davis" Message-ID: <830b4d20-26e2-02ce-76db-b63c73967e39@ti.com> Date: Tue, 19 Sep 2017 10:54:34 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1563 Lines: 35 On 09/19/2017 08:36 AM, Rob Herring wrote: > On Mon, Sep 18, 2017 at 3:50 PM, Andrew F. Davis wrote: >> On TI platforms OP-TEE must be called using a modified SMC call, >> allow the selection of this though DT. >> >> Signed-off-by: Andrew F. Davis >> --- >> Documentation/devicetree/bindings/arm/firmware/linaro,optee-tz.txt | 2 ++ >> drivers/tee/optee/core.c | 2 ++ >> 2 files changed, 4 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/arm/firmware/linaro,optee-tz.txt b/Documentation/devicetree/bindings/arm/firmware/linaro,optee-tz.txt >> index d38834c67dff..a3275ecdf186 100644 >> --- a/Documentation/devicetree/bindings/arm/firmware/linaro,optee-tz.txt >> +++ b/Documentation/devicetree/bindings/arm/firmware/linaro,optee-tz.txt >> @@ -20,6 +20,8 @@ the reference implementation maintained by Linaro. >> "hvc" : HVC #0, with the register assignments specified >> in drivers/tee/optee/optee_smc.h >> >> + "ti-smc" : Similar to "smc" with TI specific register >> + adjustments > > Sigh, really? IMO, this should be determined from the compatible > string. Then the next TI (or any vendor) specific thing can be handled > without a DT change. > Which compatible string, do you mean the OP-TEE driver check the top level platform compatible string? > Maybe some day we'll figure out that not just h/w needs to be > probe-able, but all the firmware pieces do too. > > Rob >