Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751700AbdISP7V (ORCPT <rfc822;w@1wt.eu>);
        Tue, 19 Sep 2017 11:59:21 -0400
Received: from mail-wm0-f50.google.com ([74.125.82.50]:50689 "EHLO
        mail-wm0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751655AbdISP7T (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 19 Sep 2017 11:59:19 -0400
X-Google-Smtp-Source: AOwi7QDmnkw8qiV/MSC/rdfB/6xO/QT9SEtPMhVcfMj/4DN/fs7TWRqWM9sCcY+vSgXWJv7oNt7KRw==
Subject: Re: [PATCH] arm64: dts: foundation-v8: Enable PSCI mode
To: Mark Rutland <mark.rutland@arm.com>
Cc: Liviu Dudau <liviu.dudau@arm.com>, Sudeep Holla <sudeep.holla@arm.com>,
        Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
        Rob Herring <robh+dt@kernel.org>,
        Catalin Marinas <catalin.marinas@arm.com>,
        Will Deacon <will.deacon@arm.com>,
        linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, patches@linaro.org
References: <20170918153832.16356-1-daniel.thompson@linaro.org>
 <20170918161248.GB5106@leverpostej>
From: Daniel Thompson <daniel.thompson@linaro.org>
Message-ID: <f0710af4-d414-1f2a-7d86-dd559a50171f@linaro.org>
Date: Tue, 19 Sep 2017 16:59:15 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.3.0
MIME-Version: 1.0
In-Reply-To: <20170918161248.GB5106@leverpostej>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1206
Lines: 40

On 18/09/17 17:12, Mark Rutland wrote:
> Hi Daniel,
> 
> On Mon, Sep 18, 2017 at 04:38:32PM +0100, Daniel Thompson wrote:
>> Currently if the Foundation model is running ARM Trusted Firmware then
>> the kernel, which is configured to use spin tables, cannot start secondary
>> processors or "power off" the simulation.
>>
>> Add a couple of labels to the include file, and introduce a new .dts
>> file that uses these to override the enable-method.
>>
>> Signed-off-by: Daniel Thompson <daniel.thompson@linaro.org>
> 
> This looks good, but has the unfortunate effect of leaving the
> (irrelevant) cpu-release-addr property in the PSCI dts files, as that's
> in the underlying dtsi file.
> 
> Could we split spin-table / PSCI parts into separate dtsi files?
> 
> e.g. have:
> 
> * foundation-v8.dtsi
> * foundation-v8-gicv{2,3}.dtsi
> * foundation-v8-{psci,spin-table}.dtsi
> 
> ... and then combine those to build the dts files we want.

Will do.

> 
> FWIW, with that:
> 
> Acked-by: Mark Rutland <mark.rutland@arm.com>

Talking about what we want... if it's all split out I might as well add 
a gicv2+psci DT as well. Will that still retain your Acked-by or do you 
want to see it first ;-) ?


Daniel.