DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E5433218E9
Date: Tue, 19 Sep 2017 12:25:12 -0400
From: Steven Rostedt <rostedt@goodmis.org>
To: "Ziqian SUN (Zamir)" <zsun@redhat.com>
Cc: linux-kernel@vger.kernel.org, mingo@redhat.com, karolherbst@gmail.com,
        ppaalanen@gmail.com, akpm@linux-foundation.org
Subject: Re: [PATCH v3] tracing: Ignore mmiotrace from kernel commandline
Message-ID: <20170919122512.1be9231f@gandalf.local.home>
In-Reply-To: <3d3bc80a-b728-e176-a280-cbfa47a6aed3@redhat.com>
References: <1505111195-31942-1-git-send-email-zsun@redhat.com>
        <3cec495b-89a5-b8c6-e319-af9f969582e0@redhat.com>
        <20170911072321.0085db2c@vmware.local.home>
        <3d3bc80a-b728-e176-a280-cbfa47a6aed3@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1289
Lines: 30

On Tue, 12 Sep 2017 20:18:35 +0800
"Ziqian SUN (Zamir)" <zsun@redhat.com> wrote:

> >> I feel the core trace printed by WARN is not so meaningful, so I use
> >> pr_warn instead.  
> > 
> > I'm fine with pr_warn, but I'm curious to what you mean by "not so
> > meaningful"? A WARN() will cause a dump stack, which usually shows up
> > as a bug in systems and more likely to be seen. But if someone is
> > adding this to the kernel command line and it's not working, they
> > should be looking for the tracer name within the dmesg anyway.
> >   
> 
> Following is the log I tried with WARN before. With WARN we have both 
> the warning message, and the stack trace. The stack trace goes into 
> stacing_set_tracer, but not showing mmiotrace. I mean, this is useful 
> for debugging, but maybe confusing for users who is willing to report 
> bugs but not a kernel geek. With pr_warn we already indicate mmiotrace 
> is ignored, and is neat.
>

I'm now leaning towards WARN() over pr_warn(). Sure it's more useful
for a kernel geek and not an everyday user, but I will counter that an
everyday user should most definitely not be enabling mmiotrace! Or
other traces for that matter.

But then again, it's not really a bug (it's a feature), so I guess I'll
just take this patch as is.

-- Steve