Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751504AbdISQtv (ORCPT ); Tue, 19 Sep 2017 12:49:51 -0400 Received: from mail-pf0-f194.google.com ([209.85.192.194]:36276 "EHLO mail-pf0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750872AbdISQtt (ORCPT ); Tue, 19 Sep 2017 12:49:49 -0400 X-Google-Smtp-Source: AOwi7QCJ+06k+93W1eJLUlDKiKqAKP73EWxxrDC6iTUbPPBaOTUzFMB6ouoY62i73t7d/sB6drw8vuM+32QTfRPquK4= MIME-Version: 1.0 In-Reply-To: <20170919140024.32563-1-shorne@gmail.com> References: <20170919140024.32563-1-shorne@gmail.com> From: Geert Uytterhoeven Date: Tue, 19 Sep 2017 18:49:48 +0200 X-Google-Sender-Auth: YPCtOOg_ybLu0flj98iQqaY6TzM Message-ID: Subject: Re: [PATCH] openrisc: dts: or1ksim: Add stdout-path To: Stafford Horne Cc: LKML , Openrisc , Rob Herring , Mark Rutland , Jonas Bonn , Stefan Kristiansson , "devicetree@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1426 Lines: 41 Hi Stafford, On Tue, Sep 19, 2017 at 4:00 PM, Stafford Horne wrote: > During reviews of the OpenRISC SMP patch series it was suggested to add > stdout-path to the SMP dts file. Add stdout-path to our other dts files > to be a good example. > > Signed-off-by: Stafford Horne > --- > arch/openrisc/boot/dts/or1ksim.dts | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/openrisc/boot/dts/or1ksim.dts b/arch/openrisc/boot/dts/or1ksim.dts > index 5d4f9027afaf..ecc30968cbcb 100644 > --- a/arch/openrisc/boot/dts/or1ksim.dts > +++ b/arch/openrisc/boot/dts/or1ksim.dts > @@ -7,6 +7,7 @@ > > chosen { > bootargs = "console=uart,mmio,0x90000000,115200"; > + stdout-path = &serial0; I think that should be: - bootargs = "console=uart,mmio,0x90000000,115200"; + stdout-path = "serial0:115200"; If stdout-path is present, it will become the default console. All other UART parameters except for the serial speed are derived from the serial0 node (= serial@90000000) in DT. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds