Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751520AbdISQvM (ORCPT ); Tue, 19 Sep 2017 12:51:12 -0400 Received: from mailhub.sw.ru ([195.214.232.25]:13049 "EHLO relay.sw.ru" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750872AbdISQvL (ORCPT ); Tue, 19 Sep 2017 12:51:11 -0400 From: Vasily Averin Subject: [PATCH] KEYS: key refcounting cleanup in keyctl_read_key To: keyrings@vger.kernel.org Cc: David Howells , linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org, James Morris , "Serge E. Hallyn" , Konstantin Khorenko Message-ID: <065a1f03-a342-c47c-ea6f-b4cc84f869bb@virtuozzo.com> Date: Tue, 19 Sep 2017 19:51:08 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 805 Lines: 24 key_put is lost if key_permission() returns non-EACCES error Fixes: 29db919063406 ("Keys: Add LSM hooks for key management [try #3]") Reported-by: Konstantin Khorenko Signed-off-by: Vasily Averin --- security/keys/keyctl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/security/keys/keyctl.c b/security/keys/keyctl.c index ab0b337..70efb2d 100644 --- a/security/keys/keyctl.c +++ b/security/keys/keyctl.c @@ -771,7 +771,7 @@ long keyctl_read_key(key_serial_t keyid, char __user *buffer, size_t buflen) if (ret == 0) goto can_read_key; if (ret != -EACCES) - goto error; + goto error2; /* we can't; see if it's searchable from this process's keyrings * - we automatically take account of the fact that it may be -- 2.7.4